Clean up some nits in base::NativeLibrary.

Clean up some nits in base::NativeLibrary.

- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().

Committed: https://crrev.com/e38fbd6442ba3bd87a14f1a663d42a75df664adf
Cr-Commit-Position: refs/heads/master@{#399285}

[Lei Zhang, 2016-06-07 00:36:26]

Description was changed from

==========
Clean up some nits in base::NativeLibrary.
==========

to

==========
Clean up some nits in base::NativeLibrary.

- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().
==========

[Lei Zhang, 2016-06-07 01:24:40]

thestig@chromium.org changed reviewers:
+ thomasvl@chromium.org

[Lei Zhang, 2016-06-07 01:24:40]

Please review the entire CL and native_library_mac.mm in particular.

[Lei Zhang, 2016-06-07 01:25:40]

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac.mm
File base/native_library_mac.mm (left):

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac...
base/native_library_mac.mm:26: // See if the the image contains an "ObjC image
info" segment. This method
And self-reviewing after sending out the CL... I probably should retain the
comment and just remove line 30, right?

[Lei Zhang, 2016-06-07 01:39:52]

+xhwang FYI

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac.mm
File base/native_library_mac.mm (right):

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac...
base/native_library_mac.mm:117: return name.as_string() +
ASCIIToUTF16(".dylib");
BTW, I suspect this is wrong, and it should be lib${foo}.dylib, as seen in my
mac's component build's out directory, and the references to
libclearkeycdm.dylib. Looking to fix this and get rid of the ifdefs surrounding
the references to libclearkeycdm.dylib in C++ code.

[xhwang, 2016-06-07 16:39:26]

xhwang@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-06-07 16:39:27]

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac.mm
File base/native_library_mac.mm (right):

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac...
base/native_library_mac.mm:117: return name.as_string() +
ASCIIToUTF16(".dylib");
On 2016/06/07 01:39:52, Lei Zhang (Slow) wrote:
> BTW, I suspect this is wrong, and it should be lib${foo}.dylib, as seen in my
> mac's component build's out directory, and the references to
> libclearkeycdm.dylib. Looking to fix this and get rid of the ifdefs
surrounding
> the references to libclearkeycdm.dylib in C++ code.

+1

[TVL, 2016-06-07 18:02:57]

Is any of this time critical or can it wait for mark to get back?  Normally I'm
just a backup for when he is out if something critical comes up.

[Lei Zhang, 2016-06-08 00:05:58]

On 2016/06/07 18:02:57, TVL wrote:
> Is any of this time critical or can it wait for mark to get back?  Normally
I'm
> just a backup for when he is out if something critical comes up.

It's just cleanup. Feel free to take yourself off and put mark on instead.

[TVL, 2016-06-08 00:07:43]

thomasvl@chromium.org changed reviewers:
+ mark@chromium.org
- thomasvl@chromium.org

[Lei Zhang, 2016-06-10 19:12:57]

Resending now that mark is back.

[Mark Mentovai, 2016-06-10 20:06:18]

LGTM

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac.mm
File base/native_library_mac.mm (right):

https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac...
base/native_library_mac.mm:117: return name.as_string() +
ASCIIToUTF16(".dylib");
Lei Zhang wrote:
> BTW, I suspect this is wrong, and it should be lib${foo}.dylib, as seen in my
> mac's component build's out directory, and the references to
> libclearkeycdm.dylib. Looking to fix this and get rid of the ifdefs
surrounding
> the references to libclearkeycdm.dylib in C++ code.

If you fix this, fix the header too.

[Lei Zhang, 2016-06-10 20:16:08]

On 2016/06/10 20:06:18, Mark Mentovai wrote:
> LGTM
> 
>
https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac.mm
> File base/native_library_mac.mm (right):
> 
>
https://codereview.chromium.org/2042103002/diff/40001/base/native_library_mac...
> base/native_library_mac.mm:117: return name.as_string() +
> ASCIIToUTF16(".dylib");
> Lei Zhang wrote:
> > BTW, I suspect this is wrong, and it should be lib${foo}.dylib, as seen in
my
> > mac's component build's out directory, and the references to
> > libclearkeycdm.dylib. Looking to fix this and get rid of the ifdefs
> surrounding
> > the references to libclearkeycdm.dylib in C++ code.
> 
> If you fix this, fix the header too.

Will do in the next CL. I also restored the comment to
base/native_library_mac.mm without the 32-bit portion.

[Lei Zhang, 2016-06-10 20:16:29]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-06-10 20:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2042103002/#ps60001
(title: "restore comment")

[commit-bot: I haz the power, 2016-06-10 20:16:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042103002/60001

[commit-bot: I haz the power, 2016-06-10 21:54:54]

Description was changed from

==========
Clean up some nits in base::NativeLibrary.

- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().
==========

to

==========
Clean up some nits in base::NativeLibrary.

- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().
==========

[commit-bot: I haz the power, 2016-06-10 21:54:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-10 21:55:03]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 21:57:21]

Description was changed from

==========
Clean up some nits in base::NativeLibrary.

- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().
==========

to

==========
Clean up some nits in base::NativeLibrary.

- Use StringPiece in more places.
- Don't bother with base:: in namespace base.
- Remove dead 32-bit Mac code.
- Add test for GetNativeLibraryName().

Committed: https://crrev.com/e38fbd6442ba3bd87a14f1a663d42a75df664adf
Cr-Commit-Position: refs/heads/master@{#399285}
==========

[commit-bot: I haz the power, 2016-06-10 21:57:22]

Patchset 4 (id:??) landed as
https://crrev.com/e38fbd6442ba3bd87a14f1a663d42a75df664adf
Cr-Commit-Position: refs/heads/master@{#399285}