Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issue 2042083002: Add role lists to ChromeVox. (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add role lists to ChromeVox. - add lists for forms, headings, landmarks, links, and tables. - fix some focusing issues with menus BUG=617670 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b0b4c0099b04f00b117595a762d09eb3e692f944 Cr-Commit-Position: refs/heads/master@{#398658}

Patch Set 1 #

Patch Set 2 : /chromevox/background/keymaps$ git cl upload #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -37 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json View 1 2 chunks +50 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 2 6 chunks +49 lines, -20 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 2 6 chunks +46 lines, -14 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 2 chunks +57 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 2 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
David Tseng
4 years, 6 months ago (2016-06-06 22:15:08 UTC) #4
dmazzoni
lgtm Great!!! Visually I think we may have too many top-level menus now, they may ...
4 years, 6 months ago (2016-06-07 16:36:07 UTC) #5
David Tseng
https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json File chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json (right): https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json#newcode354 chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:354: "command": "toggleKeyboardHelp", On 2016/06/07 16:36:06, dmazzoni wrote: > Why ...
4 years, 6 months ago (2016-06-08 19:28:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042083002/40001
4 years, 6 months ago (2016-06-08 19:29:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-08 20:25:56 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:27:30 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b0b4c0099b04f00b117595a762d09eb3e692f944
Cr-Commit-Position: refs/heads/master@{#398658}

Powered by Google App Engine
This is Rietveld 408576698