Add role lists to ChromeVox.

Add role lists to ChromeVox.

- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus

BUG=617670
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b0b4c0099b04f00b117595a762d09eb3e692f944
Cr-Commit-Position: refs/heads/master@{#398658}

[David Tseng, 2016-06-06 22:09:50]

Description was changed from

==========
Add role lists to ChromeVox.
==========

to

==========
Add role lists to ChromeVox.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-06 22:14:59]

Description was changed from

==========
Add role lists to ChromeVox.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Add role lists to ChromeVox.

- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus

BUG=617670

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-06 22:15:00]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-06-07 16:36:07]

lgtm

Great!!!

Visually I think we may have too many top-level menus now, they may get
squished. But this is fine for now, I think I'll just need to implement
submenus.

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:354:
"command": "toggleKeyboardHelp",
Why was this changed?

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:1068:
* @param {function()=} opt_callback
nit: indentation

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:336:
Panel.addNodeMenu('table_strategy', node, AutomationPredicate.table);
Is this just because 'table_strategy' already exists? I'd prefer if you just
call it 'role_table' and add a new string, or alternatively add a little system
for synonym strings. I'd just prefer for this code to be more clear.

Same for the keymap file where you used 'table_strategy'.

[David Tseng, 2016-06-08 19:28:33]

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:354:
"command": "toggleKeyboardHelp",
On 2016/06/07 16:36:06, dmazzoni wrote:
> Why was this changed?

Classic command name. We've started to make command names the same in the past
batch of cls (for touch, panel menus, etc).

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:1068:
* @param {function()=} opt_callback
On 2016/06/07 16:36:06, dmazzoni wrote:
> nit: indentation

Done.

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
(right):

https://codereview.chromium.org/2042083002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js:336:
Panel.addNodeMenu('table_strategy', node, AutomationPredicate.table);
On 2016/06/07 16:36:06, dmazzoni wrote:
> Is this just because 'table_strategy' already exists? I'd prefer if you just
> call it 'role_table' and add a new string, or alternatively add a little
system
> for synonym strings. I'd just prefer for this code to be more clear.
> 
> Same for the keymap file where you used 'table_strategy'.

Done.

[David Tseng, 2016-06-08 19:29:10]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-06-08 19:29:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2042083002/#ps40001
(title: " ")

[David Tseng, 2016-06-08 19:29:19]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2016-06-08 19:29:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042083002/40001

[commit-bot: I haz the power, 2016-06-08 20:25:55]

Description was changed from

==========
Add role lists to ChromeVox.

- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus

BUG=617670

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Add role lists to ChromeVox.

- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus

BUG=617670

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-08 20:25:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 20:27:29]

Description was changed from

==========
Add role lists to ChromeVox.

- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus

BUG=617670

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Add role lists to ChromeVox.

- add lists for forms, headings, landmarks, links, and tables.
- fix some focusing issues with menus

BUG=617670

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b0b4c0099b04f00b117595a762d09eb3e692f944
Cr-Commit-Position: refs/heads/master@{#398658}
==========

[commit-bot: I haz the power, 2016-06-08 20:27:30]

Patchset 3 (id:??) landed as
https://crrev.com/b0b4c0099b04f00b117595a762d09eb3e692f944
Cr-Commit-Position: refs/heads/master@{#398658}