Silencing console messages during some layout tests.

third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt

Index: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt
diff --git a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt b/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt
index d2d2617c208f64b9a5694a32c9d0410757e40c21..7ef22e9a431ad0272713b71fdc8794016c8ef12f 100644
--- a/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt
+++ b/third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt
@@ -1,3 +1 @@
-CONSOLE ERROR: line 4: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/frameNavigation/resources/ready.html' from frame with URL 'http://localhost:8000/security/frameNavigation/resources/not-opener-helper.html'. The frame attempting navigation is neither same-origin with the target, nor is it the target's parent or opener.

[alexmos, 2016/06/07 00:02:15]

Hmm, after looking closer, I think we might need to do a bit more work before
removing this.  The test is currently set up with three windows:
A (not-opener.html) opens A2 (ready.html) and B (not-opener-helper.html).  Then
B tries to navigate A2 to ready.html (confusingly, the page it's already on). 
If the navigation is denied, we should open a new window, which will load
ready.html and send back the "pass" message to not-opener-helper.html (window
B), which triggers cleanup.  If we regress in the future, however, and this
navigation is allowed, we will reload ready.html into A2, which will also send
back the "pass" message to B and perform the same cleanup (except there will be
three windows instead of four, so one of the close() calls will fail - probably
transparently to the test).  So this message was really the only indication that
the navigation failed (unless I missed something?).

Could we add an additional check to not-opener-helper.html that there are four
windows, similarly to what the xss-DENIED-targeted-link-navigation.html test is
already doing?  I think that should give us equivalent coverage.  And/or, check
from window A that A2 didn't navigate (meaning that B will probably need to use
another target URL).

There isn't something like dumpAllOpenedWindowsAsText, is there?

[Łukasz Anforowicz, 2016/06/07 22:54:41]

Thanks for catching this - much appreciated.
I've added
log("There are currently " + testRunner.windowCount() + " windows opened.");
to not-opener.html

This should be sufficient to verify that the last step you pointed out above has
not reused one of the old windows.
There actually is testRunner.dumpCreateView which dumps a line whenever
WebViewClient::createView is called during a test, but in case of
not-opener.html this only covers creation of the 2 helper windows at the start
of the test.

-
 PASS