third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt - Issue 2042043002: Silencing console messages during some layout tests.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener-expected.txt

Issue 2042043002: Silencing console messages during some layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-can-open-windows

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/not-opener.html ('k') | third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 CONSOLE ERROR: line 4: Unsafe JavaScript attempt to initiate navigation for fram e with URL 'http://127.0.0.1:8000/security/frameNavigation/resources/ready.html' from frame with URL 'http://localhost:8000/security/frameNavigation/resources/n ot-opener-helper.html'. The frame attempting navigation is neither same-origin w ith the target, nor is it the target's parent or opener.
alexmos 2016/06/07 00:02:15 Hmm, after looking closer, I think we might need t Hmm, after looking closer, I think we might need to do a bit more work before removing this. The test is currently set up with three windows: A (not-opener.html) opens A2 (ready.html) and B (not-opener-helper.html). Then B tries to navigate A2 to ready.html (confusingly, the page it's already on). If the navigation is denied, we should open a new window, which will load ready.html and send back the "pass" message to not-opener-helper.html (window B), which triggers cleanup. If we regress in the future, however, and this navigation is allowed, we will reload ready.html into A2, which will also send back the "pass" message to B and perform the same cleanup (except there will be three windows instead of four, so one of the close() calls will fail - probably transparently to the test). So this message was really the only indication that the navigation failed (unless I missed something?). Could we add an additional check to not-opener-helper.html that there are four windows, similarly to what the xss-DENIED-targeted-link-navigation.html test is already doing? I think that should give us equivalent coverage. And/or, check from window A that A2 didn't navigate (meaning that B will probably need to use another target URL). There isn't something like dumpAllOpenedWindowsAsText, is there? Łukasz Anforowicz 2016/06/07 22:54:41 Thanks for catching this - much appreciated. Show quoted text On 2016/06/07 00:02:15, alexmos wrote: > Hmm, after looking closer, I think we might need to do a bit more work before > removing this. The test is currently set up with three windows: > A (not-opener.html) opens A2 (ready.html) and B (not-opener-helper.html). Then > B tries to navigate A2 to ready.html (confusingly, the page it's already on). > If the navigation is denied, we should open a new window, which will load > ready.html and send back the "pass" message to not-opener-helper.html (window > B), which triggers cleanup. If we regress in the future, however, and this > navigation is allowed, we will reload ready.html into A2, which will also send > back the "pass" message to B and perform the same cleanup (except there will be > three windows instead of four, so one of the close() calls will fail - probably > transparently to the test). So this message was really the only indication that > the navigation failed (unless I missed something?). Thanks for catching this - much appreciated. Show quoted text > Could we add an additional check to not-opener-helper.html that there are four > windows, similarly to what the xss-DENIED-targeted-link-navigation.html test is > already doing? I think that should give us equivalent coverage. And/or, check > from window A that A2 didn't navigate (meaning that B will probably need to use > another target URL). I've added log("There are currently " + testRunner.windowCount() + " windows opened."); to not-opener.html This should be sufficient to verify that the last step you pointed out above has not reused one of the old windows. Show quoted text > > There isn't something like dumpAllOpenedWindowsAsText, is there? There actually is testRunner.dumpCreateView which dumps a line whenever WebViewClient::createView is called during a test, but in case of not-opener.html this only covers creation of the 2 helper windows at the start of the test.
2

3 PASS	1 PASS

OLD	NEW