Start using crypto 1.1.1 and tweak MD5 computation.

Start using crypto 1.1.1 and tweak MD5 computation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e6d2b370653f640b0ecbcf8499a2c43803165b6d

[Brian Wilkerson, 2016-06-06 18:30:37]

lgtm

[scheglov, 2016-06-06 18:37:12]

Description was changed from

==========
Start using crypto 1.1.1 and tweak MD5 computation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Start using crypto 1.1.1 and tweak MD5 computation.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e6d2b370653f640b0ecbcf8499a2c43803165b6d
==========

[scheglov, 2016-06-06 18:37:14]

Committed patchset #1 (id:1) manually as
e6d2b370653f640b0ecbcf8499a2c43803165b6d (presubmit successful).

[Paul Berry, 2016-06-06 19:49:52]

lgtm

[Paul Berry, 2016-06-07 15:28:57]

On 2016/06/06 18:37:14, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> e6d2b370653f640b0ecbcf8499a2c43803165b6d (presubmit successful).

This commit appears to have caused a unit test failure.  Would you mind having a
look?

Repro with: python tools/test.py -aia32 --checked -mrelease -t60
pkg/analyzer/test/src/summary/incremental_cache_test

Example output:
ERROR: IncrementalCacheTest | test_getLibraryClosureBundles_exportLib
  Test failed: Caught The null object does not have a getter 'bytes'.
  
  NoSuchMethodError: method not found: 'bytes'
  Receiver: null
  Arguments: []
  dart:core-patch/object_patch.dart 42                            
Object._noSuchMethod
  dart:core-patch/object_patch.dart 45                            
Object.noSuchMethod
  package:analyzer/src/summary/incremental_cache.dart 235:19      
IncrementalCache._computeSaltedMD5OfBytes
  package:analyzer/src/summary/incremental_cache.dart 310:14      
IncrementalCache._getLibraryClosureHash.<fn>
  dart:collection-patch/compact_hash.dart 259                     
_HashVMBase&MapMixin&&_LinkedHashMapMixin.putIfAbsent
  package:analyzer/src/summary/incremental_cache.dart 308:35      
IncrementalCache._getLibraryClosureHash
  package:analyzer/src/summary/incremental_cache.dart 285:22      
IncrementalCache._getLibraryBundleKey
  package:analyzer/src/summary/incremental_cache.dart 184:18      
IncrementalCache.putLibrary
  pkg/analyzer/test/src/summary/incremental_cache_test.dart 29:11 
IncrementalCacheTest.putLibrary
  pkg/analyzer/test/src/summary/incremental_cache_test.dart 53:22 
IncrementalCacheTest.test_getLibraryClosureBundles_exportLib
  dart:mirrors-patch/mirrors_impl.dart 534                        
_LocalInstanceMirror._invoke
  dart:mirrors-patch/mirrors_impl.dart 530                        
_LocalInstanceMirror.invoke
  pkg/analyzer/test/reflective_tests.dart 153:35                   _runTest.<fn>
  dart:async/zone.dart 958                                         _rootRunUnary
  dart:async/zone.dart 837                                        
_CustomZone.runUnary
  dart:async/future_impl.dart 131                                 
_FutureListener.handleValue
  dart:async/future_impl.dart 637                                 
_Future._propagateToListeners.handleValueCallback
  dart:async/future_impl.dart 667                                 
_Future._propagateToListeners
  dart:async/future_impl.dart 477                                 
_Future._completeWithValue
  dart:async/future_impl.dart 528                                 
_Future._asyncComplete.<fn>
  dart:async/zone.dart 950                                         _rootRun
  dart:async/zone.dart 826                                        
_CustomZone.run
  dart:async/zone.dart 724                                        
_CustomZone.runGuarded
  dart:async/zone.dart 751                                        
_CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                           
_microtaskLoop
  dart:async/schedule_microtask.dart 50                           
_startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394                          
_Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                          
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                       
_RawReceivePortImpl._handleMessage

[scheglov, 2016-06-07 15:51:18]

On 2016/06/07 15:28:57, Paul Berry wrote:
> On 2016/06/06 18:37:14, scheglov wrote:
> > Committed patchset #1 (id:1) manually as
> > e6d2b370653f640b0ecbcf8499a2c43803165b6d (presubmit successful).
> 
> This commit appears to have caused a unit test failure.  Would you mind having
a
> look?
> 
> Repro with: python tools/test.py -aia32 --checked -mrelease -t60
> pkg/analyzer/test/src/summary/incremental_cache_test

Yes, it seems that migrating to the newer version of crypto cannot be done yet.
https://codereview.chromium.org/2043913003 should fix build.