Issue 2043913003: Rollback to the older version of crypto to fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2043913003: Rollback to the older version of crypto to fix build. (Closed)

Created:
4 years, 6 months ago by scheglov

Modified:
4 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Rollback to the older version of crypto to fix build. R=paulberry@google.com BUG=

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/summary/incremental_cache.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

Nit: the subject line makes it sound like we are changing the version of crypto ...

4 years, 6 months ago (2016-06-07 15:58:30 UTC) #2

scheglov

4 years, 6 months ago (2016-06-07 18:39:51 UTC) #3

Message was sent while issue was closed.

On 2016/06/07 15:58:30, Paul Berry wrote:
> Nit: the subject line makes it sound like we are changing the version of
crypto
> that we are rolling into the SDK.  Actually we're not--during the SDK build
(and
> tests), the version of crypto in the pubspec is ignored because the version of
> crypto we use comes from DEPS.  The true problem right now is that the version
> of crypto in DEPS is 1.1.0, which doesn't contain the necessary bug fix.
> 
> lgtm assuming the subject is changed appropriately.
> 
> I will start an email conversation with Kevin about whether we can safely roll
> DEPS to crypto 1.1.1, which should fix this problem for good.

We update DEPS to use crypto 1.1.1 instead.
So, I'm closing this CL.

Expand Messages | Collapse Messages