Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/interpreter/bytecode-array-writer.h

Issue 2041913002: [interpreter] Remove OperandScale from front stages of pipeline. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Minor clean-up. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-writer.h
diff --git a/src/interpreter/bytecode-array-writer.h b/src/interpreter/bytecode-array-writer.h
index 696f13abb665817ac2a9eaf8887e43ccb4c94e1b..5595206a082a676674ba306016a7bfe079aced48 100644
--- a/src/interpreter/bytecode-array-writer.h
+++ b/src/interpreter/bytecode-array-writer.h
@@ -34,6 +34,15 @@ class BytecodeArrayWriter final : public BytecodePipelineStage {
Handle<FixedArray> handler_table) override;
private:
+ // Constants that act as placeholders for jump operands to be
+ // patched. These have operand sizes that match the sizes of
+ // reserved constant pool entries.
+ static const uint32_t k8BitPlaceholder = 0x7f;
rmcilroy 2016/06/07 10:32:46 kJump8BitPlaceholder (and similar)
oth 2016/06/08 15:08:41 Done.
+ static const uint32_t k16BitPlaceholder =
+ k8BitPlaceholder | (k8BitPlaceholder << 8);
+ static const uint32_t k32BitPlaceholder =
+ k16BitPlaceholder | (k16BitPlaceholder << 16);
+
void PatchJump(size_t jump_target, size_t jump_location);
void PatchJumpWith8BitOperand(size_t jump_location, int delta);
void PatchJumpWith16BitOperand(size_t jump_location, int delta);

Powered by Google App Engine
This is Rietveld 408576698