[interpreter] Remove OperandScale from front stages of pipeline.

src/interpreter/bytecode-array-builder.h

Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 3cdea52aae08488f00109c26786080664407301e..2364fe794b6de3f642bf95bf1ed2907ceaac8169 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -277,7 +277,7 @@ class BytecodeArrayBuilder final : public ZoneObject {
 
   static uint32_t RegisterOperand(Register reg);
   static Register RegisterFromOperand(uint32_t operand);
-  static uint32_t SignedOperand(int value, OperandSize size);
+  static uint32_t SignedOperand(int value);
   static uint32_t UnsignedOperand(int value);
   static uint32_t UnsignedOperand(size_t value);

[rmcilroy, 2016/06/07 10:32:46]

Do we need the differentiation between signed and unsigned here any longer? I
think we could just have ToOperand(int/size_t) and do the checks for correct
size for signed / unsigned in bytecode array builder?

[oth, 2016/06/08 15:08:41]

It's doable, but doing the check upfront means it fails immediately rather than
after going through the pipeline. The status quo seems better here, WDYT?

 
@@ -297,24 +297,16 @@ class BytecodeArrayBuilder final : public ZoneObject {
   static Bytecode BytecodeForCall(TailCallMode tail_call_mode);
 
   void Output(Bytecode bytecode);
-  void OutputScaled(Bytecode bytecode, OperandScale operand_scale,
-                    uint32_t operand0, uint32_t operand1, uint32_t operand2,
-                    uint32_t operand3);
-  void OutputScaled(Bytecode bytecode, OperandScale operand_scale,
-                    uint32_t operand0, uint32_t operand1, uint32_t operand2);
-  void OutputScaled(Bytecode bytecode, OperandScale operand_scale,
-                    uint32_t operand0, uint32_t operand1);
-  void OutputScaled(Bytecode bytecode, OperandScale operand_scale,
-                    uint32_t operand0);
+  void Output(Bytecode bytecode, uint32_t operand0, uint32_t operand1,
+              uint32_t operand2, uint32_t operand3);
+  void Output(Bytecode bytecode, uint32_t operand0, uint32_t operand1,
+              uint32_t operand2);
+  void Output(Bytecode bytecode, uint32_t operand0, uint32_t operand1);
+  void Output(Bytecode bytecode, uint32_t operand0);
 
   BytecodeArrayBuilder& OutputJump(Bytecode jump_bytecode,
                                    BytecodeLabel* label);
 
-
-  bool OperandIsValid(Bytecode bytecode, OperandScale operand_scale,
-                      int operand_index, uint32_t operand_value) const;
-  bool RegisterIsValid(Register reg, OperandSize reg_size) const;
-
   // Attach latest source position to |node|.
   void AttachSourceInfo(BytecodeNode* node);