Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: net/spdy/spdy_session.h

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index ec98d3c873a6d400662f5805b1ec88e245648e18..bd7a739d1499b13fe28d01bad132b22969a94156 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -292,7 +292,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// |session| is the HttpNetworkSession. |net_log| is the NetLog that we log
// network events to.
SpdySession(const SpdySessionKey& spdy_session_key,
- const base::WeakPtr<HttpServerProperties>& http_server_properties,
+ HttpServerProperties* const http_server_properties,
asanka 2016/06/07 20:19:56 Const value arguments in a declarations are a no-o
Bence 2016/06/08 18:27:18 Done.
TransportSecurityState* transport_security_state,
bool verify_domain_authentication,
bool enable_sending_initial_data,
@@ -1026,7 +1026,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// |pool_| owns us, therefore its lifetime must exceed ours.
SpdySessionPool* pool_;
- const base::WeakPtr<HttpServerProperties> http_server_properties_;
+ HttpServerProperties* const http_server_properties_;
asanka 2016/06/07 20:19:56 Doesn't match surrounding code to mark just this p
Bence 2016/06/08 18:27:18 Done.
TransportSecurityState* transport_security_state_;

Powered by Google App Engine
This is Rietveld 408576698