Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 2041863002: Remove HttpServerProperies::GetWeakPtr(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index 85b17e50b16f102b9a4d3149d051bd41ccaa3fde..e9ef06e649a4a4a33f3b4eae3a9de10b4e1f0a42 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -111,7 +111,7 @@ void UpdateSpdySessionDependencies(SpdyNetworkTransactionTestParams test_params,
session_deps->enable_alternative_service_with_different_host = true;
if (test_params.ssl_type == HTTP_SPDY_VIA_ALT_SVC) {
base::Time expiration = base::Time::Now() + base::TimeDelta::FromDays(1);
- session_deps->http_server_properties.SetAlternativeService(
+ session_deps->http_server_properties->SetAlternativeService(
url::SchemeHostPort("http", "www.example.org", 80),
AlternativeService(AlternateProtocolFromNextProto(test_params.protocol),
"www.example.org", 443),
@@ -4587,7 +4587,7 @@ TEST_P(SpdyNetworkTransactionTest, HTTP11RequiredRetry) {
ssl_provider1->SetNextProto(kProtoHTTP11);
helper.AddDataWithSSLSocketDataProvider(&data1, std::move(ssl_provider1));
- base::WeakPtr<HttpServerProperties> http_server_properties =
+ HttpServerProperties* http_server_properties =
helper.session()->spdy_session_pool()->http_server_properties();
const HostPortPair host_port_pair = HostPortPair::FromURL(GURL(url));
EXPECT_FALSE(http_server_properties->RequiresHTTP11(host_port_pair));
@@ -4692,7 +4692,7 @@ TEST_P(SpdyNetworkTransactionTest, HTTP11RequiredProxyRetry) {
helper.session_deps()->socket_factory->AddSSLSocketDataProvider(
ssl_provider2.get());
- base::WeakPtr<HttpServerProperties> http_server_properties =
+ HttpServerProperties* http_server_properties =
helper.session()->spdy_session_pool()->http_server_properties();
const HostPortPair proxy_host_port_pair = HostPortPair("myproxy", 70);
EXPECT_FALSE(http_server_properties->RequiresHTTP11(proxy_host_port_pair));

Powered by Google App Engine
This is Rietveld 408576698