Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 2041723004: Reland to M-52: Make revalidation to fail when received a redirect response (Closed)

Created:
4 years, 6 months ago by hiroshige
Modified:
4 years, 6 months ago
Reviewers:
kinuko, Nate Chapin, *yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Reland to M-52: Make revalidation to fail when received a redirect response In addition to the original CL [1], this CL de-Oilpanize DummyClient because DummyClient is on-heap in M-53 due to [2] but not in M-52. [1] https://codereview.chromium.org/2017883002 [2] https://codereview.chromium.org/1998073002 BUG=614989 Review-Url: https://codereview.chromium.org/2017883002 Cr-Commit-Position: refs/heads/master@{#397650} (cherry picked from commit a9531777113bf6e6ea527c1ec34bbb65a128b560) R=japhet@chromium.org, kinuko@chromium.org, yhirano@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/66988329a1011173517bbbc9d01e1c8273eb2079

Patch Set 1 #

Patch Set 2 : Manual Change to merge to M-52: De-Oilpanize DummyClient. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 1 3 chunks +83 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hiroshige
PTAL. This is manual merging CL of [1] to M-52. yhirano@ as the author of ...
4 years, 6 months ago (2016-06-06 18:48:18 UTC) #4
Nate Chapin
lgtm
4 years, 6 months ago (2016-06-06 19:18:04 UTC) #5
yhirano
lgtm
4 years, 6 months ago (2016-06-07 08:20:28 UTC) #6
kinuko
lgtm
4 years, 6 months ago (2016-06-07 08:30:37 UTC) #7
hiroshige
4 years, 6 months ago (2016-06-07 09:00:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
66988329a1011173517bbbc9d01e1c8273eb2079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698