Move some ResourceClients for testing to Oilpan heap

Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyClient
 - AddingClient
 - RemovingClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
Committed: https://crrev.com/8781609dba554ba04a4b81fcb3ebc4c2c939c85f
Cr-Commit-Position: refs/heads/master@{#395869}

[yhirano, 2016-05-20 06:13:29]

Description was changed from

==========
onheap test resource clients


wip

BUG=
==========

to

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyResourceClient
 - AddingResourceClient
 - RemovingResourceClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
==========

[yhirano, 2016-05-20 06:20:41]

Description was changed from

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyResourceClient
 - AddingResourceClient
 - RemovingResourceClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
==========

to

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyClient
 - AddingClient
 - RemovingClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
==========

[yhirano, 2016-05-20 06:24:44]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org, japhet@chromium.org

[yhirano, 2016-05-20 06:24:44]

I use Persistent instead of raw pointers because clients are held as raw
pointers in Resource.

[haraken, 2016-05-20 07:37:38]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-05-20 07:37:39]

LGTM

https://codereview.chromium.org/1998073002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MockResourceClients.cpp (right):

https://codereview.chromium.org/1998073002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockResourceClients.cpp:66:
toImageResource(m_resource.get())->removeObserver(this);

Not related to this CL, we might want to move ImageResourceObserver to the heap
as well.

[yhirano, 2016-05-20 07:45:46]

https://codereview.chromium.org/1998073002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MockResourceClients.cpp (right):

https://codereview.chromium.org/1998073002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MockResourceClients.cpp:66:
toImageResource(m_resource.get())->removeObserver(this);
On 2016/05/20 07:37:38, haraken wrote:
> 
> Not related to this CL, we might want to move ImageResourceObserver to the
heap
> as well.

LayoutObject inherits ImageResourceObserver and according to Elliot it will not
be moved to Oilpan heap. Actually, that's why we decoupled ImageResourceObserver
from ResourceClient.

[Nate Chapin, 2016-05-23 21:57:50]

lgtm

[yhirano, 2016-05-25 05:24:55]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-05-25 05:25:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998073002/40001

[commit-bot: I haz the power, 2016-05-25 10:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 10:55:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yhirano, 2016-05-25 10:55:26]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-05-25 10:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1998073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1998073002/40001

[commit-bot: I haz the power, 2016-05-25 12:12:24]

Description was changed from

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyClient
 - AddingClient
 - RemovingClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
==========

to

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyClient
 - AddingClient
 - RemovingClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
==========

[commit-bot: I haz the power, 2016-05-25 12:12:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-25 12:14:12]

Description was changed from

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyClient
 - AddingClient
 - RemovingClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663
==========

to

==========
Move some ResourceClients for testing to Oilpan heap

This change moves the following classes to Oilpan heap.

 - MockResourceClient
 - MockImageResourceClient
 - DummyClient
 - AddingClient
 - RemovingClient
 - ServeRequetsOnCompleteClient
 - RequestSameResourceOnComplete

All classes are for testing.

BUG=587663

Committed: https://crrev.com/8781609dba554ba04a4b81fcb3ebc4c2c939c85f
Cr-Commit-Position: refs/heads/master@{#395869}
==========

[commit-bot: I haz the power, 2016-05-25 12:14:14]

Patchset 3 (id:??) landed as
https://crrev.com/8781609dba554ba04a4b81fcb3ebc4c2c939c85f
Cr-Commit-Position: refs/heads/master@{#395869}