Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2041603002: [ios Mojo] Implemented chrome://version.

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo_version
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios Mojo] Implemented chrome://version. BUG=

Patch Set 1 #

Patch Set 2 : Merged with origin/master #

Patch Set 3 : Reverted unnecessary changes #

Patch Set 4 : Self review #

Patch Set 5 : Rebased #

Patch Set 6 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -80 lines) Patch
M components/resources/version_ui_resources.grdp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M components/version_ui/resources/about_version.js View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
D components/version_ui/resources/about_version_ios.js View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
M components/version_ui/version_handler_helper.h View 2 1 chunk +0 lines, -5 lines 0 comments Download
M components/version_ui/version_handler_helper.cc View 2 1 chunk +0 lines, -13 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_handler.h View 1 2 3 4 1 chunk +12 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_handler.cc View 1 2 3 4 1 chunk +20 lines, -13 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.h View 1 2 3 4 5 1 chunk +12 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.mm View 1 2 3 4 5 2 chunks +10 lines, -4 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/ios_chrome_resources.gyp View 1 2 3 4 3 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041603002/60001
4 years, 6 months ago (2016-06-10 15:29:49 UTC) #2
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 15:31:55 UTC) #4 
Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

Powered by Google App Engine
This is Rietveld 408576698