Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: ios/chrome/browser/ui/webui/version_handler.cc

Issue 2041603002: [ios Mojo] Implemented chrome://version. Base URL: https://chromium.googlesource.com/chromium/src.git@mojo_version
Patch Set: Self review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/webui/version_handler.h ('k') | ios/chrome/browser/ui/webui/version_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/version_handler.cc
diff --git a/ios/chrome/browser/ui/webui/version_handler.cc b/ios/chrome/browser/ui/webui/version_handler.cc
index fc2d7e0b3a73d75c09cff92a0977b548bef883d7..e670e88a7992ddd38593fe460f32f6294155415a 100644
--- a/ios/chrome/browser/ui/webui/version_handler.cc
+++ b/ios/chrome/browser/ui/webui/version_handler.cc
@@ -4,27 +4,34 @@
#include "ios/chrome/browser/ui/webui/version_handler.h"
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/values.h"
#include "components/version_ui/version_handler_helper.h"
#include "components/version_ui/version_ui_constants.h"
#include "ios/web/public/webui/web_ui_ios.h"
#include "ui/base/l10n/l10n_util.h"
-VersionHandler::VersionHandler() {}
+VersionHandler::VersionHandler(
+ mojo::InterfaceRequest<mojom::VersionPageHandler> request)
+ : binding_(this, std::move(request)) {}
VersionHandler::~VersionHandler() {}
-void VersionHandler::RegisterMessages() {
- web_ui()->RegisterMessageCallback(
- version_ui::kRequestVersionInfo,
- base::Bind(&VersionHandler::HandleRequestVersionInfo,
- base::Unretained(this)));
+void VersionHandler::GetFilePaths(const GetFilePathsCallback& callback) {
+ NOTREACHED();
}
-void VersionHandler::HandleRequestVersionInfo(const base::ListValue* args) {
- // Respond with the variations info immediately.
- web_ui()->CallJavascriptFunction(version_ui::kReturnVariationInfo,
- *version_ui::GetVariationsList());
+void VersionHandler::GetFlashVersion(const GetFlashVersionCallback& callback) {
+ NOTREACHED();
+}
+
+void VersionHandler::GetVariations(const GetVariationsCallback& callback) {
+ std::vector<std::string> variations = version_ui::GetVariations();
+ callback.Run(mojo::Array<mojo::String>::From(variations));
+}
+
+void VersionHandler::GetOsVersion(const GetOsVersionCallback& callback) {
+ NOTREACHED();
+}
+
+void VersionHandler::GetArcVersion(const GetArcVersionCallback& callback) {
+ NOTREACHED();
}
« no previous file with comments | « ios/chrome/browser/ui/webui/version_handler.h ('k') | ios/chrome/browser/ui/webui/version_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698