third_party/guava/BUILD.gn - Issue 2041583002: Add guava to chromium third party

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/guava/BUILD.gn

Issue 2041583002: Add guava to chromium third party (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/android/rules.gni")

	6

	7 android_java_prebuilt("guava") {
	mikecase (-- gone --) 2016/06/07 20:52:40 As another sidenote. I know a lot of java targets As another sidenote. I know a lot of java targets are named like <name>_java (so, guava_java). Don't know if there really is a naming convention to follow though. Yoland Yan(Google) 2016/06/08 20:34:00 Done. (also changed in other CLs) Show quoted text On 2016/06/07 20:52:40, mikecase wrote: > As another sidenote. I know a lot of java targets are named like <name>_java > (so, guava_java). Don't know if there really is a naming convention to follow > though. Done. (also changed in other CLs)
	8 jar_path = "lib/guava-18.0.jar"

	9 }

OLD	NEW