Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2041543002: Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" (Closed)

Created:
4 years, 6 months ago by emircan
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" Because we came across issues in some CrOS platforms in HW H264 encode, we decided to revert this CL such that HW H264 is only enabled for MacOSX. Please see the bug below for details. BUG=615272 Review-Url: https://codereview.chromium.org/2030833002 Cr-Commit-Position: refs/heads/master@{#397601} (cherry picked from commit d7e93a2d1bae10c260230a1de7c5d9f1f0272d03) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/renderer/media/rtc_video_encoder_factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
emircan
4 years, 6 months ago (2016-06-03 21:45:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041543002/1
4 years, 6 months ago (2016-06-03 21:46:26 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 21:48:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698