Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2030833002:
Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" (Closed)
|
Created:
4 years, 6 months ago by emircan Modified:
4 years, 6 months ago Reviewers:
mcasas CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available"
Because we came across issues in some CrOS platforms in HW H264 encode,
we decided to revert this CL such that HW H264 is only enabled for MacOSX.
Please see the bug below for details.
BUG=615272
Committed: https://crrev.com/d7e93a2d1bae10c260230a1de7c5d9f1f0272d03
Cr-Commit-Position: refs/heads/master@{#397601}
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This reverts commit 6468142875bd0d0b1064965e82c4b04747cac2fd. BUG= ========== to ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This reverts commit 6468142875bd0d0b1064965e82c4b04747cac2fd. BUG=615272 ==========
emircan@chromium.org changed reviewers: + posciak@chromium.org
emircan@chromium.org changed reviewers: + mcasas@chromium.org
PTAL.
emircan@chromium.org changed reviewers: - posciak@chromium.org
On 2016/06/02 05:41:49, emircan wrote: > PTAL. If it's a revert, then rather try going to that CL and clicking on the "revert patchset" button, so it's easy to track in the original bug and CL that it has been reverted. Otherwise, please add more context in the CL description, like: "... because it crashes in X platform, see bug" and if you add a commit id, make it a link plz. So, assuming this CL cannot be auto-reverted, and seeing that is verbatim revert of the original https://codereview.chromium.org/1972333002, RS LGTM.
Description was changed from ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" This reverts commit 6468142875bd0d0b1064965e82c4b04747cac2fd. BUG=615272 ========== to ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" Because we came across issues in some CrOS platforms in HW H264 encode, we decided to revert this CL such that HW H264 is only enabled for MacOSX. Please see the bug below for details. BUG=615272 ==========
The CQ bit was checked by emircan@chromium.org
Thanks. I updated the description as well.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030833002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030833002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030833002/1
Message was sent while issue was closed.
Description was changed from ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" Because we came across issues in some CrOS platforms in HW H264 encode, we decided to revert this CL such that HW H264 is only enabled for MacOSX. Please see the bug below for details. BUG=615272 ========== to ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" Because we came across issues in some CrOS platforms in HW H264 encode, we decided to revert this CL such that HW H264 is only enabled for MacOSX. Please see the bug below for details. BUG=615272 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" Because we came across issues in some CrOS platforms in HW H264 encode, we decided to revert this CL such that HW H264 is only enabled for MacOSX. Please see the bug below for details. BUG=615272 ========== to ========== Revert "Use kEnableWebRtcHWH264Encoding flag when SW fallback is available" Because we came across issues in some CrOS platforms in HW H264 encode, we decided to revert this CL such that HW H264 is only enabled for MacOSX. Please see the bug below for details. BUG=615272 Committed: https://crrev.com/d7e93a2d1bae10c260230a1de7c5d9f1f0272d03 Cr-Commit-Position: refs/heads/master@{#397601} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d7e93a2d1bae10c260230a1de7c5d9f1f0272d03 Cr-Commit-Position: refs/heads/master@{#397601} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
