Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2041513002: Remove ListValue::Append(new {Fundamental,String}Value(...)) usage in //chrome (part 2) (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) usage in //chrome (part 2) The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() This wasn't included in the original CL because the clang tool got confused when processing this file. It turns out true and false can be macros! BUG=581865 Committed: https://crrev.com/930694e095e2f25add4d39d5478a952b481332a3 Cr-Commit-Position: refs/heads/master@{#397858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc View 7 chunks +41 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 6 months ago (2016-06-03 21:30:31 UTC) #2
xiyuan
lgtm
4 years, 6 months ago (2016-06-03 21:34:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041513002/1
4 years, 6 months ago (2016-06-03 21:37:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 00:41:55 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:43:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930694e095e2f25add4d39d5478a952b481332a3
Cr-Commit-Position: refs/heads/master@{#397858}

Powered by Google App Engine
This is Rietveld 408576698