Remove ListValue::Append(new {Fundamental,String}Value(...)) usage in //chrome (part 2)

chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/signin_create_profile_handler.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_attributes_entry.h"
@@ skipping 320 matching lines @@
                        &TestSigninCreateProfileHandler::RealDoCreateProfile));
 
   // Expect no calls to register a supervised user.
   EXPECT_CALL(*handler(), RegisterSupervisedUser(_, _, _, _)).Times(0);
 
   // Expect a new browser window for the new profile to be opened.
   EXPECT_CALL(*handler(), OpenNewWindowForProfile(_, _));
 
   // Create a non-supervised profile.
   base::ListValue list_args;
-  list_args.Append(new base::StringValue(kTestProfileName));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));  // create_shortcut
-  list_args.Append(new base::FundamentalValue(false));  // is_supervised
+  list_args.AppendString(kTestProfileName);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);  // create_shortcut
+  list_args.AppendBoolean(false);  // is_supervised
   handler()->CreateProfile(&list_args);
 
   // Expect a JS callbacks with the new profile information.
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   EXPECT_EQ(kTestWebUIResponse, web_ui()->call_data()[0]->function_name());
 
   std::string callback_name;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_name));
   EXPECT_EQ("create-profile-success", callback_name);
@@ skipping 22 matching lines @@
       .WillOnce(Invoke(
             handler(),
             &TestSigninCreateProfileHandler::RealRegisterSupervisedUser));
 
   // Expect no new browser window for the new supervised profile to be opened.
   EXPECT_CALL(*handler(), OpenNewWindowForProfile(_, _)).Times(0);
 
   // Create a supervised profile.
   base::ListValue list_args;
   list_args.Clear();
-  list_args.Append(new base::StringValue(kSupervisedUsername1));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));  // create_shortcut
-  list_args.Append(new base::FundamentalValue(true));  // is_supervised
-  list_args.Append(new base::StringValue(""));  // supervised_user_id
-  list_args.Append(new base::StringValue(custodian()->GetPath().value()));
+  list_args.AppendString(kSupervisedUsername1);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);  // create_shortcut
+  list_args.AppendBoolean(true);  // is_supervised
+  list_args.AppendString("");  // supervised_user_id
+  list_args.AppendString(custodian()->GetPath().value());
   handler()->CreateProfile(&list_args);
 
   // Expect a JS callbacks with the new profile information.
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   EXPECT_EQ(kTestWebUIResponse, web_ui()->call_data()[0]->function_name());
 
   std::string callback_name;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_name));
   EXPECT_EQ("create-profile-success", callback_name);
@@ skipping 22 matching lines @@
       .WillOnce(Invoke(
             handler(),
             &TestSigninCreateProfileHandler::RealRegisterSupervisedUser));
 
   // Expect a new browser window for the new profile to be opened.
   EXPECT_CALL(*handler(), OpenNewWindowForProfile(_, _));
 
   // Import a supervised profile.
   base::ListValue list_args;
   list_args.Clear();
-  list_args.Append(new base::StringValue(kSupervisedUsername1));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));   // create_shortcut
-  list_args.Append(new base::FundamentalValue(true));  // is_supervised
-  list_args.Append(
-      new base::StringValue(kSupervisedUserId1));  // supervised_user_id
-  list_args.Append(new base::StringValue(custodian()->GetPath().value()));
+  list_args.AppendString(kSupervisedUsername1);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);   // create_shortcut
+  list_args.AppendBoolean(true);  // is_supervised
+  list_args.AppendString(
+      kSupervisedUserId1);  // supervised_user_id
+  list_args.AppendString(custodian()->GetPath().value());
   handler()->CreateProfile(&list_args);
 
   // Expect a JS callbacks with the new profile information.
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   EXPECT_EQ(kTestWebUIResponse, web_ui()->call_data()[0]->function_name());
 
   std::string callback_name;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_name));
   EXPECT_EQ("create-profile-success", callback_name);
 
   const base::DictionaryValue* profile;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg2()->GetAsDictionary(&profile));
   std::string profile_name;
   ASSERT_TRUE(profile->GetString("name", &profile_name));
   EXPECT_NE("", profile_name);
   std::string profile_path;
   ASSERT_TRUE(profile->GetString("filePath", &profile_path));
   EXPECT_NE("", profile_path);
   bool is_supervised;
   ASSERT_TRUE(profile->GetBoolean("isSupervised", &is_supervised));
   ASSERT_TRUE(is_supervised);
 }
 
 TEST_F(SigninCreateProfileHandlerTest, ImportSupervisedUserAlreadyOnDevice) {
   // Import a supervised profile whose already on the current device.
   base::ListValue list_args;
   list_args.Clear();
-  list_args.Append(new base::StringValue(kSupervisedUsername2));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));
-  list_args.Append(new base::FundamentalValue(true));
-  list_args.Append(new base::StringValue(kSupervisedUserId2));
-  list_args.Append(new base::StringValue(custodian()->GetPath().value()));
+  list_args.AppendString(kSupervisedUsername2);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);
+  list_args.AppendBoolean(true);
+  list_args.AppendString(kSupervisedUserId2);
+  list_args.AppendString(custodian()->GetPath().value());
   handler()->CreateProfile(&list_args);
 
   // Expect a JS callbacks containing an error message.
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   EXPECT_EQ(kTestWebUIResponse, web_ui()->call_data()[0]->function_name());
 
   std::string callback_name;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_name));
   EXPECT_EQ("create-profile-error", callback_name);
@@ skipping 10 matching lines @@
   SupervisedUserSyncService* sync_service_ =
       SupervisedUserSyncServiceFactory::GetForProfile(custodian());
   sync_service_->StopSyncing(syncer::SUPERVISED_USERS);
 
   // Sign out the custodian.
   signin_manager()->ForceSignOut();
 
   // Create a supervised profile.
   base::ListValue list_args;
   list_args.Clear();
-  list_args.Append(new base::StringValue(kSupervisedUsername1));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));  // create_shortcut
-  list_args.Append(new base::FundamentalValue(true));  // is_supervised
-  list_args.Append(new base::StringValue(""));  // supervised_user_id
-  list_args.Append(new base::StringValue(custodian()->GetPath().value()));
+  list_args.AppendString(kSupervisedUsername1);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);  // create_shortcut
+  list_args.AppendBoolean(true);  // is_supervised
+  list_args.AppendString("");  // supervised_user_id
+  list_args.AppendString(custodian()->GetPath().value());
   handler()->CreateProfile(&list_args);
 
   // Expect a JS callbacks containing an error message.
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   EXPECT_EQ(kTestWebUIResponse, web_ui()->call_data()[0]->function_name());
 
   std::string callback_name;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_name));
   EXPECT_EQ("create-profile-error", callback_name);
 
   base::string16 expected_error_message = l10n_util::GetStringUTF16(
       IDS_PROFILES_CREATE_CUSTODIAN_ACCOUNT_DETAILS_OUT_OF_DATE_ERROR);
   base::string16 error_message;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg2()->GetAsString(&error_message));
   EXPECT_EQ(expected_error_message, error_message);
 }
 
 TEST_F(SigninCreateProfileHandlerTest, CustodianHasAuthError) {
   // Set an Auth Error for the custodian.
   const GoogleServiceAuthError error(
       GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS);
   FakeAuthStatusProvider provider(
       SigninErrorControllerFactory::GetForProfile(custodian()));
   provider.SetAuthError(kTestGaiaId1, error);
 
   // Create a supervised profile.
   base::ListValue list_args;
   list_args.Clear();
-  list_args.Append(new base::StringValue(kSupervisedUsername1));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));  // create_shortcut
-  list_args.Append(new base::FundamentalValue(true));  // is_supervised
-  list_args.Append(new base::StringValue(""));  // supervised_user_id
-  list_args.Append(new base::StringValue(custodian()->GetPath().value()));
+  list_args.AppendString(kSupervisedUsername1);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);  // create_shortcut
+  list_args.AppendBoolean(true);  // is_supervised
+  list_args.AppendString("");  // supervised_user_id
+  list_args.AppendString(custodian()->GetPath().value());
   handler()->CreateProfile(&list_args);
 
   // Expect a JS callbacks containing an error message.
   EXPECT_EQ(1U, web_ui()->call_data().size());
 
   EXPECT_EQ(kTestWebUIResponse, web_ui()->call_data()[0]->function_name());
 
   std::string callback_name;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg1()->GetAsString(&callback_name));
   EXPECT_EQ("create-profile-error", callback_name);
 
   base::string16 expected_error_message = l10n_util::GetStringUTF16(
       IDS_PROFILES_CREATE_CUSTODIAN_ACCOUNT_DETAILS_OUT_OF_DATE_ERROR);
   base::string16 error_message;
   ASSERT_TRUE(web_ui()->call_data()[0]->arg2()->GetAsString(&error_message));
   EXPECT_EQ(expected_error_message, error_message);
 }
 
 TEST_F(SigninCreateProfileHandlerTest, NotAllowedToCreateSupervisedUser) {
   // Custodian is not permitted to create supervised users.
   custodian()->GetPrefs()->SetBoolean(prefs::kSupervisedUserCreationAllowed,
                                       false);
 
   // Create a supervised profile.
   base::ListValue list_args;
   list_args.Clear();
-  list_args.Append(new base::StringValue(kSupervisedUsername1));
-  list_args.Append(new base::StringValue(profiles::GetDefaultAvatarIconUrl(0)));
-  list_args.Append(new base::FundamentalValue(false));  // create_shortcut
-  list_args.Append(new base::FundamentalValue(true));  // is_supervised
-  list_args.Append(new base::StringValue(""));  // supervised_user_id
-  list_args.Append(new base::StringValue(custodian()->GetPath().value()));
+  list_args.AppendString(kSupervisedUsername1);
+  list_args.AppendString(profiles::GetDefaultAvatarIconUrl(0));
+  list_args.AppendBoolean(false);  // create_shortcut
+  list_args.AppendBoolean(true);  // is_supervised
+  list_args.AppendString("");  // supervised_user_id
+  list_args.AppendString(custodian()->GetPath().value());
   handler()->CreateProfile(&list_args);
 
   // Expect nothing to happen.
   EXPECT_EQ(0U, web_ui()->call_data().size());
 }