Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2041493003: Make updateMarkerRenderedRect() to dispose temporary Range object after use (Closed)

Created:
4 years, 6 months ago by haraken
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Make updateMarkerRenderedRect() to dispose temporary Range object after use This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to dispose temporary |Range| object after use to prevent increasing number of active |Range| object for avoiding slow down of DOM mutation operations. Note: This patch is a temporary solution, we'll have |EphemeralRange| version later. BUG=613658 TEST=n/a; This is temporary solution, we'll have another solution later. Review-Url: https://codereview.chromium.org/2034753003 Cr-Commit-Position: refs/heads/master@{#397626} (cherry picked from commit 544e48708ee9286a58dfa24e0f29e30cece34f3c) Committed: https://chromium.googlesource.com/chromium/src/+/803a3ac5b77116151f02189ede18b22731de4579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
haraken
4 years, 6 months ago (2016-06-04 00:47:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
803a3ac5b77116151f02189ede18b22731de4579.

Powered by Google App Engine
This is Rietveld 408576698