Make updateMarkerRenderedRect() to dispose temporary Range object after use

Make updateMarkerRenderedRect() to dispose temporary Range object after use

This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to
dispose temporary |Range| object after use to prevent increasing number of
active |Range| object for avoiding slow down of DOM mutation operations.

Note: This patch is a temporary solution, we'll have |EphemeralRange| version
later.

BUG=613658
TEST=n/a; This is temporary solution, we'll have another solution later.

Committed: https://crrev.com/544e48708ee9286a58dfa24e0f29e30cece34f3c
Cr-Commit-Position: refs/heads/master@{#397626}

[yosin_UTC9, 2016-06-03 02:08:02]

Description was changed from

==========
2016-06-03T11:02:34

BUG=
==========

to

==========
Make updateMarkerRenderedRect() to dispose temporary Range object after use

This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to
dispose temporary |Range| object after use to prevent increasing number of
active |Range| object for avoiding slow down of DOM mutation operations.

Note: This patch is a temporary solution, we'll have |EphemeralRange| version
later.

BUG=613658
TEST=n/a; This is temporary solution, we'll have another solution later.
==========

[yosin_UTC9, 2016-06-03 02:08:02]

yosin@chromium.org changed reviewers:
+ haraken@chromium.org, keishi@chromium.org, yoichio@chromium.org

[yoichio, 2016-06-03 02:10:08]

https://codereview.chromium.org/2034753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2034753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:198:
if (exceptionState.hadException())
You should add range->dispose() in this line too.

[yosin_UTC9, 2016-06-03 02:13:49]

PTAL

Add another Range::dispose()

https://codereview.chromium.org/2034753003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
(right):

https://codereview.chromium.org/2034753003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:198:
if (exceptionState.hadException())
On 2016/06/03 at 02:10:08, yoichio wrote:
> You should add range->dispose() in this line too.

Good catch!
This is reason why we should migrate to EphmeralRange.

[yoichio, 2016-06-03 02:15:42]

lgtm

[yosin_UTC9, 2016-06-03 02:15:58]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-06-03 02:16:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034753003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034753003/20001

[haraken, 2016-06-03 02:35:19]

LGTM, thanks for the great fix!!

[commit-bot: I haz the power, 2016-06-03 04:20:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-03 04:23:25]

Description was changed from

==========
Make updateMarkerRenderedRect() to dispose temporary Range object after use

This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to
dispose temporary |Range| object after use to prevent increasing number of
active |Range| object for avoiding slow down of DOM mutation operations.

Note: This patch is a temporary solution, we'll have |EphemeralRange| version
later.

BUG=613658
TEST=n/a; This is temporary solution, we'll have another solution later.
==========

to

==========
Make updateMarkerRenderedRect() to dispose temporary Range object after use

This patch makes |updateMarkerRenderedRect()| in |DocumentMarkerController| to
dispose temporary |Range| object after use to prevent increasing number of
active |Range| object for avoiding slow down of DOM mutation operations.

Note: This patch is a temporary solution, we'll have |EphemeralRange| version
later.

BUG=613658
TEST=n/a; This is temporary solution, we'll have another solution later.

Committed: https://crrev.com/544e48708ee9286a58dfa24e0f29e30cece34f3c
Cr-Commit-Position: refs/heads/master@{#397626}
==========

[commit-bot: I haz the power, 2016-06-03 04:23:26]

Patchset 2 (id:??) landed as
https://crrev.com/544e48708ee9286a58dfa24e0f29e30cece34f3c
Cr-Commit-Position: refs/heads/master@{#397626}