Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2041353003: [runtime] Deprecate RUNTIME_ASSERT from primitive ops. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Deprecate RUNTIME_ASSERT from primitive ops. This removes explicit uses of the RUNTIME_ASSERT macro from some runtime methods. The implicit ones in CONVERT_FOO_ARG_CHECKED will be addressed in a separate CL for all runtime modules at once. R=verwaest@chromium.org BUG=v8:5066 Committed: https://crrev.com/8e02f47ea1e648038a126869215479aaca00c7fe Cr-Commit-Position: refs/heads/master@{#36815}

Patch Set 1 #

Patch Set 2 : Thank you C, for your handling of signed/unsigned compares. #

Patch Set 3 : Fix failures. #

Patch Set 4 : Addressed offline comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -59 lines) Patch
M src/runtime/runtime-array.cc View 1 2 3 4 chunks +8 lines, -7 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 2 10 chunks +18 lines, -19 lines 0 comments Download
M src/runtime/runtime-symbol.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D test/mjsunit/regress/regress-449070.js View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-07 15:12:59 UTC) #1
Toon Verwaest
Awesome, lgtm.
4 years, 6 months ago (2016-06-08 08:55:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041353003/60001
4 years, 6 months ago (2016-06-08 09:18:30 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-08 09:27:13 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 09:29:34 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8e02f47ea1e648038a126869215479aaca00c7fe
Cr-Commit-Position: refs/heads/master@{#36815}

Powered by Google App Engine
This is Rietveld 408576698