src/runtime/runtime-maths.cc - Issue 2041353003: [runtime] Deprecate RUNTIME_ASSERT from primitive ops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-maths.cc

Issue 2041353003: [runtime] Deprecate RUNTIME_ASSERT from primitive ops. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed offline comment. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-maths.cc

diff --git a/src/runtime/runtime-maths.cc b/src/runtime/runtime-maths.cc

index ee8c289fea7edf919ba0ff0126e394f18b632e0e..b66219af47419f4e64efc460f9a30029629e7c99 100644

--- a/src/runtime/runtime-maths.cc

+++ b/src/runtime/runtime-maths.cc

@@ -52,7 +52,7 @@ RUNTIME_FUNCTION(Runtime_RemPiO2) {

DCHECK(args.length() == 2);

CONVERT_DOUBLE_ARG_CHECKED(x, 0);

CONVERT_ARG_CHECKED(JSTypedArray, result, 1);

- RUNTIME_ASSERT(result->byte_length() == Smi::FromInt(2 * sizeof(double)));

+ CHECK(result->byte_length() == Smi::FromInt(2 * sizeof(double)));

FixedFloat64Array* array = FixedFloat64Array::cast(result->elements());

double* y = static_cast<double*>(array->DataPtr());

return Smi::FromInt(fdlibm::rempio2(x, y));

« no previous file with comments | « src/runtime/runtime-literals.cc ('k') | src/runtime/runtime-numbers.cc » ('j') | no next file with comments »