Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gni/isolate.gni

Issue 2041303002: [gn] Fix gyp/gn translation of use_snapshot (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gni/isolate.gni
diff --git a/gni/isolate.gni b/gni/isolate.gni
index a5e1937368b88be594aebeeca6358f7fb5447495..4626002113951de7f0a8068a0c7f5dabdcd56d50 100644
--- a/gni/isolate.gni
+++ b/gni/isolate.gni
@@ -96,9 +96,9 @@ template("v8_isolate_run") {
use_external_startup_data = "0"
}
if (v8_use_snapshot) {
- use_snapshot = "1"
+ use_snapshot = "true"
Michael Achenbach 2016/06/07 07:59:28 "true", really? Yes :/
} else {
- use_snapshot = "0"
+ use_snapshot = "false"
}
# Note, all paths will be rebased in isolate_driver.py to be relative to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698