Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: gni/isolate.gni

Issue 2041303002: [gn] Fix gyp/gn translation of use_snapshot (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("v8.gni") 6 import("v8.gni")
7 7
8 declare_args() { 8 declare_args() {
9 # Sets the test isolation mode (noop|prepare|check). 9 # Sets the test isolation mode (noop|prepare|check).
10 v8_test_isolation_mode = "noop" 10 v8_test_isolation_mode = "noop"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 icu_use_data_file_flag = "1" 89 icu_use_data_file_flag = "1"
90 } else { 90 } else {
91 icu_use_data_file_flag = "0" 91 icu_use_data_file_flag = "0"
92 } 92 }
93 if (v8_use_external_startup_data) { 93 if (v8_use_external_startup_data) {
94 use_external_startup_data = "1" 94 use_external_startup_data = "1"
95 } else { 95 } else {
96 use_external_startup_data = "0" 96 use_external_startup_data = "0"
97 } 97 }
98 if (v8_use_snapshot) { 98 if (v8_use_snapshot) {
99 use_snapshot = "1" 99 use_snapshot = "true"
Michael Achenbach 2016/06/07 07:59:28 "true", really? Yes :/
100 } else { 100 } else {
101 use_snapshot = "0" 101 use_snapshot = "false"
102 } 102 }
103 103
104 # Note, all paths will be rebased in isolate_driver.py to be relative to 104 # Note, all paths will be rebased in isolate_driver.py to be relative to
105 # the isolate file. 105 # the isolate file.
106 args = [ 106 args = [
107 v8_test_isolation_mode, 107 v8_test_isolation_mode,
108 "--isolated", 108 "--isolated",
109 rebase_path("$root_out_dir/$name.isolated", root_build_dir), 109 rebase_path("$root_out_dir/$name.isolated", root_build_dir),
110 "--isolate", 110 "--isolate",
111 rebase_path(invoker.isolate, root_build_dir), 111 rebase_path(invoker.isolate, root_build_dir),
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 ] 161 ]
162 } else { 162 } else {
163 args += [ 163 args += [
164 "--config-variable", 164 "--config-variable",
165 "msvs_version=0", 165 "msvs_version=0",
166 ] 166 ]
167 } 167 }
168 } 168 }
169 } 169 }
170 } 170 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698