Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2041303002: [gn] Fix gyp/gn translation of use_snapshot (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix gyp/gn translation of use_snapshot BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Committed: https://crrev.com/a61cae100b3a5bea69d30f95aa04c394cddae70c Cr-Commit-Position: refs/heads/master@{#36774}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gni/isolate.gni View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR https://codereview.chromium.org/2041303002/diff/1/gni/isolate.gni File gni/isolate.gni (right): https://codereview.chromium.org/2041303002/diff/1/gni/isolate.gni#newcode99 gni/isolate.gni:99: use_snapshot = "true" "true", really? Yes :/
4 years, 6 months ago (2016-06-07 07:59:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041303002/1
4 years, 6 months ago (2016-06-07 07:59:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 08:01:24 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a61cae100b3a5bea69d30f95aa04c394cddae70c Cr-Commit-Position: refs/heads/master@{#36774}
4 years, 6 months ago (2016-06-07 08:02:54 UTC) #9
vogelheim
4 years, 6 months ago (2016-06-07 08:05:59 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698