Remove the use of OwnedPtrDeleter in WebHelperPlugin.

third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

Index: third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
index c13253ba8501a9317f5c06d65ad52ddeec50619c..d293cc4f22419ab0405dbd6bfaedf92784aab7e6 100644
--- a/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
+++ b/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
@@ -43,10 +43,10 @@ DEFINE_TYPE_CASTS(WebHelperPluginImpl, WebHelperPlugin, plugin, true, true);
 
 WebHelperPlugin* WebHelperPlugin::create(const WebString& pluginType, WebLocalFrame* frame)

[tzik, 2016/06/07 06:57:18]

Does our policy forbid to return std::unique_ptr here?
If not, could you replace the raw ptr here with unique_ptr.

[Yuta Kitamura, 2016/06/07 07:21:03]

I think that's okay; would like to hear from dcheng on
the context on the design of this.

[dcheng, 2016/06/07 17:10:32]

For other Blink public APIs, we tried to avoid exposing the refcounting nature
of Blink in the public API, so we used create() / destroy() / close() functions.

I don't think that applies here though: this thing has unique ownership, so we
should probably just return std::unique_ptr and make things simpler.
Unfortunately, it looks like destroy() deletes the object in a timer... ideally
we should try to get rid of the need for the custom deleter if we expose it. Can
you see if it's still necessary?

 {
-    OwnPtr<WebHelperPlugin> plugin = adoptPtr<WebHelperPlugin>(new WebHelperPluginImpl());
+    WebHelperPluginUniquePtr plugin(new WebHelperPluginImpl());
     if (!toWebHelperPluginImpl(plugin.get())->initialize(pluginType, toWebLocalFrameImpl(frame)))
         return 0;
-    return plugin.leakPtr();
+    return plugin.release();
 }
 
 WebHelperPluginImpl::WebHelperPluginImpl()