Remove the use of OwnedPtrDeleter in WebHelperPlugin.

third_party/WebKit/Source/web/WebHelperPluginImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "public/web/WebPlugin.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebPluginContainerImpl.h"
 
 namespace blink {
 
 DEFINE_TYPE_CASTS(WebHelperPluginImpl, WebHelperPlugin, plugin, true, true);
 
 WebHelperPlugin* WebHelperPlugin::create(const WebString& pluginType, WebLocalFrame* frame)

[tzik, 2016/06/07 06:57:18]

Does our policy forbid to return std::unique_ptr here?
If not, could you replace the raw ptr here with unique_ptr.

[Yuta Kitamura, 2016/06/07 07:21:03]

I think that's okay; would like to hear from dcheng on
the context on the design of this.

[dcheng, 2016/06/07 17:10:32]

For other Blink public APIs, we tried to avoid exposing the refcounting nature
of Blink in the public API, so we used create() / destroy() / close() functions.

I don't think that applies here though: this thing has unique ownership, so we
should probably just return std::unique_ptr and make things simpler.
Unfortunately, it looks like destroy() deletes the object in a timer... ideally
we should try to get rid of the need for the custom deleter if we expose it. Can
you see if it's still necessary?

 {
-    OwnPtr<WebHelperPlugin> plugin = adoptPtr<WebHelperPlugin>(new WebHelperPluginImpl());
+    WebHelperPluginUniquePtr plugin(new WebHelperPluginImpl());
     if (!toWebHelperPluginImpl(plugin.get())->initialize(pluginType, toWebLocalFrameImpl(frame)))
         return 0;
-    return plugin.leakPtr();
+    return plugin.release();
 }
 
 WebHelperPluginImpl::WebHelperPluginImpl()
     : m_destructionTimer(this, &WebHelperPluginImpl::reallyDestroy)
 {
 }
 
 WebHelperPluginImpl::~WebHelperPluginImpl()
 {
     // TODO(Oilpan): it is potentially problematic to support plugin
@@ skipping 46 matching lines @@
 }
 
 WebPlugin* WebHelperPluginImpl::getPlugin()
 {
     DCHECK(m_pluginContainer);
     DCHECK(m_pluginContainer->plugin());
     return m_pluginContainer->plugin();
 }
 
 } // namespace blink