Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2041233004: mash: Move //ash/session to //ash/common/session (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, achuith+watch_chromium.org, sadrul, dtseng+watch_chromium.org, derat+watch_chromium.org, michaelpg+watch-options_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, dzhioev+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, tfarina, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move //ash/session to //ash/common/session * Add GetSessionStateDelegate() accessor to WmShell * Remove existing WmShell wrapper functions for SessionStateDelegate * Add a stub SessionStateDelegate to //ash/mus * Move the files * Clean up some #includes along the way BUG=615155 TEST=existing ash_unittests and chrome unit_tests Committed: https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb Cr-Commit-Position: refs/heads/master@{#398451}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -402 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 2 chunks +1 line, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 3 chunks +5 lines, -9 lines 0 comments Download
A + ash/common/session/session_state_delegate.h View 2 chunks +4 lines, -6 lines 0 comments Download
A + ash/common/session/session_state_delegate.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + ash/common/session/session_state_observer.h View 3 chunks +6 lines, -9 lines 0 comments Download
A + ash/common/session/session_state_observer.cc View 1 chunk +7 lines, -9 lines 0 comments Download
A + ash/common/session/session_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/wm/container_finder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/wm/workspace/workspace_layout_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/common/wm_shell.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/content/shell_content_state.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/media_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 4 chunks +71 lines, -11 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/session/session_state_delegate.h View 1 chunk +0 lines, -134 lines 0 comments Download
D ash/session/session_state_delegate.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/session/session_state_observer.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ash/session/session_state_observer.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/session/session_types.h View 1 chunk +0 lines, -16 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 3 chunks +1 line, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_locking_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_locking_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_locking_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/cast/tray_cast.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_default_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/media_security/multi_profile_media_tray_item.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/login_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user_separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shell_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_session_state_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_focus_rules_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session_login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_content_state_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/network_connect_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
James Cook
sky, please take a look. https://codereview.chromium.org/2041233004/diff/1/ash/ash.gyp File ash/ash.gyp (right): https://codereview.chromium.org/2041233004/diff/1/ash/ash.gyp#newcode70 ash/ash.gyp:70: 'common/session/session_types.h', This one was ...
4 years, 6 months ago (2016-06-07 21:30:00 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-07 22:14:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233004/1
4 years, 6 months ago (2016-06-07 23:03:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/83637) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 23:11:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233004/20001
4 years, 6 months ago (2016-06-07 23:33:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/83708)
4 years, 6 months ago (2016-06-08 00:40:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041233004/20001
4 years, 6 months ago (2016-06-08 00:49:43 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 01:34:19 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 01:35:27 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b624c5a101e9440b71ad963b1d21ebf56f185eb
Cr-Commit-Position: refs/heads/master@{#398451}

Powered by Google App Engine
This is Rietveld 408576698