Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2041193006: exo: Only create new SurfaceLayer if layer properties change. (Closed)

Created:
4 years, 6 months ago by jbauman
Modified:
4 years, 6 months ago
Reviewers:
reveman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Only create new SurfaceLayer if layer properties change. This allows us to avoid an unnecessary browser compositor commit and draw if only the contents of the buffer change, which saves CPU. BUG=610086 Committed: https://crrev.com/f4c3f293f20d87a6383da5c8d2df4763d89f2999 Cr-Commit-Position: refs/heads/master@{#399339}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 11

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -123 lines) Patch
M components/exo/pointer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/sub_surface.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/exo/surface.h View 1 2 4 chunks +43 lines, -34 lines 0 comments Download
M components/exo/surface.cc View 1 2 23 chunks +134 lines, -89 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
jbauman
4 years, 6 months ago (2016-06-08 21:10:16 UTC) #3
reveman
https://codereview.chromium.org/2041193006/diff/1/components/exo/surface.cc File components/exo/surface.cc (right): https://codereview.chromium.org/2041193006/diff/1/components/exo/surface.cc#newcode272 components/exo/surface.cc:272: modified_layer_info_ = true; Can we evaluate this as part ...
4 years, 6 months ago (2016-06-09 14:19:29 UTC) #4
jbauman
On 2016/06/09 14:19:29, reveman wrote: > https://codereview.chromium.org/2041193006/diff/1/components/exo/surface.cc > File components/exo/surface.cc (right): > > https://codereview.chromium.org/2041193006/diff/1/components/exo/surface.cc#newcode272 > ...
4 years, 6 months ago (2016-06-09 18:25:31 UTC) #5
reveman
On 2016/06/09 at 18:25:31, jbauman wrote: > On 2016/06/09 14:19:29, reveman wrote: > > https://codereview.chromium.org/2041193006/diff/1/components/exo/surface.cc ...
4 years, 6 months ago (2016-06-09 18:48:49 UTC) #6
jbauman
On 2016/06/09 18:48:49, reveman wrote: > On 2016/06/09 at 18:25:31, jbauman wrote: > > On ...
4 years, 6 months ago (2016-06-09 21:46:18 UTC) #7
reveman
lgtm with a bunch of naming nits https://codereview.chromium.org/2041193006/diff/20001/components/exo/surface.cc File components/exo/surface.cc (right): https://codereview.chromium.org/2041193006/diff/20001/components/exo/surface.cc#newcode430 components/exo/surface.cc:430: if (has_pending_contents_ ...
4 years, 6 months ago (2016-06-10 03:42:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041193006/40001
4 years, 6 months ago (2016-06-11 00:53:27 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-11 00:57:45 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-11 00:57:59 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 01:00:31 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4c3f293f20d87a6383da5c8d2df4763d89f2999
Cr-Commit-Position: refs/heads/master@{#399339}

Powered by Google App Engine
This is Rietveld 408576698