Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2041103004: Report buildbucket ID for all builds (Closed)

Created:
4 years, 6 months ago by Sergiy Byelozyorov
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tests #

Patch Set 3 : Fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M infra/tools/send_monitoring_event/send_event.py View 3 chunks +5 lines, -1 line 1 comment Download
M infra_libs/event_mon/monitoring.py View 5 chunks +12 lines, -3 lines 0 comments Download
M infra_libs/event_mon/test/monitoring_test.py View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Sergiy Byelozyorov
4 years, 6 months ago (2016-06-07 19:50:17 UTC) #1
Sergey Berezin
Code LGTM. How about some tests for the new field?
4 years, 6 months ago (2016-06-07 19:54:50 UTC) #2
Sergiy Byelozyorov
On 2016/06/07 19:54:50, Sergey Berezin wrote: > Code LGTM. How about some tests for the ...
4 years, 6 months ago (2016-06-07 19:55:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041103004/20001
4 years, 6 months ago (2016-06-07 19:55:34 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041103004/40001
4 years, 6 months ago (2016-06-07 20:21:20 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 20:27:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2041103004/40001
4 years, 6 months ago (2016-06-08 17:08:24 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/ca9eede9002b7fa3268829c3e993e45537919281
4 years, 6 months ago (2016-06-08 17:11:23 UTC) #14
pgervais
4 years, 6 months ago (2016-06-09 16:38:49 UTC) #16
Message was sent while issue was closed. 
https://codereview.chromium.org/2041103004/diff/40001/infra/tools/send_monito...
File infra/tools/send_monitoring_event/send_event.py (right):

https://codereview.chromium.org/2041103004/diff/40001/infra/tools/send_monito...
infra/tools/send_monitoring_event/send_event.py:129:
build_group.add_argument('--build-event-bbucket-id',
After-the fact drive-by: I think it's always better to avoid abbreviation.

Powered by Google App Engine
This is Rietveld 408576698