Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: infra_libs/event_mon/monitoring.py

Issue 2041103004: Report buildbucket ID for all builds (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra_libs/event_mon/monitoring.py
diff --git a/infra_libs/event_mon/monitoring.py b/infra_libs/event_mon/monitoring.py
index e9cc475e409d8531b15e14553558032c531e070a..b896d588e79eb8ef93a730c4d9b3233149f495c5 100644
--- a/infra_libs/event_mon/monitoring.py
+++ b/infra_libs/event_mon/monitoring.py
@@ -271,7 +271,8 @@ def get_build_event(event_type,
goma_stats=None,
goma_error=None,
goma_crash_report_id=None,
- patch_url=None):
+ patch_url=None,
+ bbucket_id=None):
"""Compute a ChromeInfraEvent filled with a BuildEvent.
Arguments are identical to those in send_build_event(), please refer
@@ -338,6 +339,11 @@ def get_build_event(event_type,
event.build_event.step_number = step_number
if patch_url is not None:
event.build_event.patch_url = patch_url
+ if bbucket_id is not None:
+ try:
+ event.build_event.bbucket_id = int(bbucket_id)
+ except (ValueError, TypeError):
+ pass
if event.build_event.step_name:
if event_type != 'STEP':
@@ -432,7 +438,8 @@ def send_build_event(event_type,
goma_stats=None,
goma_error=None,
goma_crash_report_id=None,
- patch_url=None):
+ patch_url=None,
+ bbucket_id=None):
"""Send a ChromeInfraEvent filled with a BuildEvent
Args:
@@ -460,6 +467,7 @@ def send_build_event(event_type,
goma_error (string): goma error type defined as GomaErrorType.
goma_crash_report_id (string): id of goma crash report.
patch_url (string): URL of the patch that triggered build
+ bbucket_id (long): Buildbucket ID of the build.
Returns:
success (bool): False if some error happened.
@@ -479,7 +487,8 @@ def send_build_event(event_type,
goma_stats=goma_stats,
goma_error=goma_error,
goma_crash_report_id=goma_crash_report_id,
- patch_url=patch_url).send()
+ patch_url=patch_url,
+ bbucket_id=bbucket_id).send()
def send_events(events):

Powered by Google App Engine
This is Rietveld 408576698