Issue 2041093003: Surface sync error icon if sync is off may be unintentional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2041093003: Surface sync error icon if sync is off may be unintentional (Closed)

Created:
4 years, 6 months ago by gogerald1

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Surface sync error icon if sync is off may be unintentional This CL is a strength of https://codereview.chromium.org/1952853005/. BUG=607695 Review-Url: https://codereview.chromium.org/2032043002 Cr-Commit-Position: refs/heads/master@{#398097} (cherry picked from commit 93018d6d6d5fc9bd3d54addc498d296187af6423) Committed: https://chromium.googlesource.com/chromium/src/+/0dd7cb915974f7e6dcc246d7484b1597049cf206

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -7 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/preferences/SyncPreference.java	View		2 chunks	+32 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

gogerald1

4 years, 6 months ago (2016-06-06 20:39:11 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0dd7cb915974f7e6dcc246d7484b1597049cf206.