Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4515)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java

Issue 2041093003: Surface sync error icon if sync is off may be unintentional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/SyncPreference.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
index 7e0bc7678e6dcbd87831b8b87d2c2eeceab58509..a2ae34dcce3420ff09ab152a322096089036719c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SignInPreference.java
@@ -23,8 +23,6 @@ import org.chromium.chrome.browser.signin.AccountSigninActivity;
import org.chromium.chrome.browser.signin.SigninAccessPoint;
import org.chromium.chrome.browser.signin.SigninManager;
import org.chromium.chrome.browser.signin.SigninManager.SignInAllowedObserver;
-import org.chromium.chrome.browser.sync.GoogleServiceAuthError;
-import org.chromium.chrome.browser.sync.ProfileSyncService;
import org.chromium.sync.AndroidSyncSettings;
import org.chromium.sync.signin.ChromeSigninController;
@@ -95,7 +93,7 @@ public class SignInPreference extends Preference implements SignInAllowedObserve
}
title = TextUtils.isEmpty(cachedName) ? account.name : cachedName;
}
- if (ProfileSyncService.get().getAuthError() != GoogleServiceAuthError.State.NONE) {
+ if (SyncPreference.showSyncErrorIcon(getContext())) {
setWidgetLayoutResource(R.layout.sync_error_widget);
} else {
setWidgetLayoutResource(0);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/SyncPreference.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698