Prevent use of GPU IDC in Resourceless Software Draw

Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035913002
Cr-Commit-Position: refs/heads/master@{#397547}
(cherry picked from commit 2af3e47380eb2a2a4ebb3b22c654b1881c722ccc)

Committed: https://chromium.googlesource.com/chromium/src/+/6b6095a611dc659fa5e3dc6d98f20fc63ab510c6

[ericrk, 2016-06-06 18:36:04]

Description was changed from

==========
Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035913002
Cr-Commit-Position: refs/heads/master@{#397547}
(cherry picked from commit 2af3e47380eb2a2a4ebb3b22c654b1881c722ccc)
==========

to

==========
Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2035913002
Cr-Commit-Position: refs/heads/master@{#397547}
(cherry picked from commit 2af3e47380eb2a2a4ebb3b22c654b1881c722ccc)

Committed:
https://chromium.googlesource.com/chromium/src/+/6b6095a611dc659fa5e3dc6d98f2...
==========

[ericrk, 2016-06-06 18:36:05]

Committed patchset #1 (id:1) manually as
6b6095a611dc659fa5e3dc6d98f20fc63ab510c6.