Differentiate GN config settings for core vs third party code

Differentiate GN config settings for core vs third party code

Have different settings for core source code vs third_party code so
it is a bit easier to fine tune settings.

Committed: https://pdfium.googlesource.com/pdfium/+/0abe65264043b8a1b4afbf8d3e9ce88b4a534826

[Wei Li, 2016-06-06 19:12:44]

Description was changed from

==========
Differentiate config settings for PDFium core vs third party code

Have different settings for core source code vs third_party code so
it is a bit easier to fine tune settings.
==========

to

==========
Differentiate GN config settings for core vs third party code

Have different settings for core source code vs third_party code so
it is a bit easier to fine tune settings.
==========

[Wei Li, 2016-06-06 19:25:12]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-06-06 19:44:07]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Wei Li, 2016-06-06 19:44:07]

for review, thanks

[dsinclair, 2016-06-06 19:54:41]

lgtm w/ question.

https://codereview.chromium.org/2041053003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2041053003/diff/20001/BUILD.gn#newcode52
BUILD.gn:52: config("pdfium_third_party_config") {
Should we move this into third_party/BUILD.gn?

[Wei Li, 2016-06-06 21:31:59]

thanks

https://codereview.chromium.org/2041053003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2041053003/diff/20001/BUILD.gn#newcode52
BUILD.gn:52: config("pdfium_third_party_config") {
On 2016/06/06 19:54:41, dsinclair wrote:
> Should we move this into third_party/BUILD.gn?

I think either way should be fine. Moved to third_party
to be close to where it is used.

[Wei Li, 2016-06-06 21:40:58]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-06-06 21:40:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2041053003/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-06-06 21:41:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041053003/40001

[commit-bot: I haz the power, 2016-06-06 21:41:25]

Description was changed from

==========
Differentiate GN config settings for core vs third party code

Have different settings for core source code vs third_party code so
it is a bit easier to fine tune settings.
==========

to

==========
Differentiate GN config settings for core vs third party code

Have different settings for core source code vs third_party code so
it is a bit easier to fine tune settings.

Committed:
https://pdfium.googlesource.com/pdfium/+/0abe65264043b8a1b4afbf8d3e9ce88b4a53...
==========

[commit-bot: I haz the power, 2016-06-06 21:41:26]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/0abe65264043b8a1b4afbf8d3e9ce88b4a53...