Differentiate GN config settings for core vs third party code

BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build_overrides/v8.gni")
 import("//testing/test.gni")
 import("pdfium.gni")
 
-config("pdfium_config") {
+config("pdfium_common_config") {
   cflags = []
   include_dirs = [
     ".",
     "third_party/freetype/include",
     "third_party/freetype/include/freetype",
   ]
   defines = [
     "OPJ_STATIC",
     "PNG_PREFIX",
     "PNG_USE_READ_MACROS",
-    "V8_DEPRECATION_WARNINGS",
   ]
 
   if (pdf_use_skia) {
     defines += [ "_SKIA_SUPPORT_" ]
   }
 
   if (pdf_enable_v8) {
     defines += [ "PDF_ENABLE_V8" ]
   }
 
   if (pdf_enable_xfa) {
     defines += [ "PDF_ENABLE_XFA" ]
   }
+}
 
+config("pdfium_core_config") {
+  cflags = []
+  configs = [":pdfium_common_config"]
+  defines = ["V8_DEPRECATION_WARNINGS"]
   if (is_linux) {
     if (current_cpu == "x64") {
       defines += [ "_FX_CPU_=_FX_X64_" ]
       cflags += [ "-fPIC" ]
     } else if (current_cpu == "x86") {
       defines += [ "_FX_CPU_=_FX_X86_" ]
     }
   }
-
   if (is_win) {
     cflags += [ "/wd4267" ]
   }
 }
 
 config("xfa_warnings") {
   visibility = [ ":*" ]
   if (is_posix && !is_clang) {  # When GCC.
     cflags = [ "-Wno-strict-overflow" ]
   }
@@ skipping 39 matching lines @@
     "public/fpdf_progressive.h",
     "public/fpdf_save.h",
     "public/fpdf_searchex.h",
     "public/fpdf_sysfontinfo.h",
     "public/fpdf_text.h",
     "public/fpdf_transformpage.h",
     "public/fpdfview.h",
   ]
 
   libs = []
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 
   deps = [
     ":fdrm",
     ":formfiller",
     ":fpdfapi",
     ":fpdfdoc",
     ":fpdftext",
     ":fxcodec",
     ":fxcrt",
     ":fxedit",
@@ skipping 49 matching lines @@
     deps += [
       "//v8",
       "//v8:v8_libplatform",
     ]
     include_dirs += [
       "//v8",
       "//v8/include",
     ]
     configs += [ "//v8:external_startup_data" ]
   }
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 # Targets below this are only visible within this file (and to the
 # top-level gn_visibility target used to help gn_all build everything).
 visibility = [
   ":*",
   "//:gn_visibility",
 ]
 
 static_library("fdrm") {
   sources = [
     "core/fdrm/crypto/fx_crypt.cpp",
     "core/fdrm/crypto/fx_crypt_aes.cpp",
     "core/fdrm/crypto/fx_crypt_sha.cpp",
     "core/fdrm/crypto/include/fx_crypt.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("fpdfdoc") {
   sources = [
     "core/fpdfdoc/cpdf_variabletext.cpp",
     "core/fpdfdoc/cpvt_color.cpp",
     "core/fpdfdoc/cpvt_color.h",
     "core/fpdfdoc/cpvt_dash.h",
     "core/fpdfdoc/cpvt_floatrect.h",
     "core/fpdfdoc/cpvt_fontmap.cpp",
@@ skipping 29 matching lines @@
     "core/fpdfdoc/include/cpvt_word.h",
     "core/fpdfdoc/include/cpvt_wordplace.h",
     "core/fpdfdoc/include/cpvt_wordprops.h",
     "core/fpdfdoc/include/cpvt_wordrange.h",
     "core/fpdfdoc/include/fpdf_doc.h",
     "core/fpdfdoc/include/fpdf_tagged.h",
     "core/fpdfdoc/ipvt_fontmap.h",
     "core/fpdfdoc/pdf_vt.h",
     "core/fpdfdoc/tagged_int.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("fpdfapi") {
   sources = [
     "core/fpdfapi/cpdf_modulemgr.cpp",
     "core/fpdfapi/fpdf_cmaps/CNS1/Adobe-CNS1-UCS2_5.cpp",
     "core/fpdfapi/fpdf_cmaps/CNS1/B5pc-H_0.cpp",
     "core/fpdfapi/fpdf_cmaps/CNS1/B5pc-V_0.cpp",
     "core/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-H_0.cpp",
     "core/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-V_0.cpp",
@@ skipping 206 matching lines @@
     "core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp",
     "core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp",
     "core/fpdfapi/fpdf_render/fpdf_render_text.cpp",
     "core/fpdfapi/fpdf_render/include/cpdf_progressiverenderer.h",
     "core/fpdfapi/fpdf_render/include/cpdf_rendercontext.h",
     "core/fpdfapi/fpdf_render/include/cpdf_renderoptions.h",
     "core/fpdfapi/fpdf_render/include/cpdf_textrenderer.h",
     "core/fpdfapi/fpdf_render/render_int.h",
     "core/fpdfapi/include/cpdf_modulemgr.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("fpdftext") {
   sources = [
     "core/fpdftext/fpdf_text_int.cpp",
     "core/fpdftext/include/cpdf_linkextract.h",
     "core/fpdftext/include/cpdf_textpage.h",
     "core/fpdftext/include/cpdf_textpagefind.h",
     "core/fpdftext/text_int.h",
     "core/fpdftext/unicodenormalizationdata.cpp",
     "core/fpdftext/unicodenormalizationdata.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("fxcodec") {
   deps = [
     "third_party:fx_lcms2",
     "third_party:fx_libopenjpeg",
     "third_party:fx_zlib",
 
     # This is a generic JPEG library dependency.
     "//third_party:jpeg",
@@ skipping 79 matching lines @@
     deps += [
       "third_party:fx_lpng",
       "third_party:fx_tiff",
     ]
   }
   if (is_posix) {
     # core/fxcodec/fx_libopenjpeg/src/fx_mct.c does an pointer-to-int
     # conversion to check that an address is 16-bit aligned (benign).
     cflags_c = [ "-Wno-pointer-to-int-cast" ]
   }
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 config("fxge_warnings") {
   if (is_clang) {
     cflags = [
       # http://code.google.com/p/pdfium/issues/detail?id=188
       "-Wno-switch",
     ]
   }
 }
@@ skipping 41 matching lines @@
     "core/fxcrt/xml_int.h",
   ]
   if (pdf_enable_xfa) {
     sources += [
       "core/fxcrt/fx_arabic.cpp",
       "core/fxcrt/fx_arabic.h",
       "core/fxcrt/fx_basic_maps.cpp",
       "core/fxcrt/include/fx_arb.h",
     ]
   }
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("fxge") {
   sources = [
     "core/fxge/android/fpf_skiafont.cpp",
     "core/fxge/android/fpf_skiafont.h",
     "core/fxge/android/fpf_skiafontmgr.cpp",
     "core/fxge/android/fpf_skiafontmgr.h",
     "core/fxge/android/fpf_skiamodule.cpp",
     "core/fxge/android/fpf_skiamodule.h",
@@ skipping 40 matching lines @@
     "core/fxge/include/fx_dib.h",
     "core/fxge/include/fx_font.h",
     "core/fxge/include/fx_freetype.h",
     "core/fxge/include/fx_ge.h",
     "core/fxge/include/fx_ge_apple.h",
     "core/fxge/include/fx_ge_win32.h",
   ]
 
   configs += [
     ":fxge_warnings",
-    ":pdfium_config",
+    ":pdfium_core_config",
   ]
 
   if (pdf_use_skia) {
     sources += [ "core/fxge/skia/fx_skia_device.cpp" ]
     deps = [
       "//skia",
     ]
   } else {
     sources += [
       "core/fxge/agg/fx_agg_driver.cpp",
@@ skipping 22 matching lines @@
   sources = [
     "fpdfsdk/fxedit/fxet_ap.cpp",
     "fpdfsdk/fxedit/fxet_edit.cpp",
     "fpdfsdk/fxedit/fxet_list.cpp",
     "fpdfsdk/fxedit/fxet_module.cpp",
     "fpdfsdk/fxedit/fxet_pageobjs.cpp",
     "fpdfsdk/fxedit/include/fx_edit.h",
     "fpdfsdk/fxedit/include/fxet_edit.h",
     "fpdfsdk/fxedit/include/fxet_list.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("pdfwindow") {
   sources = [
     "fpdfsdk/pdfwindow/PWL_Button.cpp",
     "fpdfsdk/pdfwindow/PWL_Button.h",
     "fpdfsdk/pdfwindow/PWL_Caret.cpp",
     "fpdfsdk/pdfwindow/PWL_Caret.h",
     "fpdfsdk/pdfwindow/PWL_ComboBox.cpp",
     "fpdfsdk/pdfwindow/PWL_ComboBox.h",
@@ skipping 17 matching lines @@
     "fpdfsdk/pdfwindow/PWL_ScrollBar.h",
     "fpdfsdk/pdfwindow/PWL_Signature.cpp",
     "fpdfsdk/pdfwindow/PWL_Signature.h",
     "fpdfsdk/pdfwindow/PWL_SpecialButton.cpp",
     "fpdfsdk/pdfwindow/PWL_SpecialButton.h",
     "fpdfsdk/pdfwindow/PWL_Utils.cpp",
     "fpdfsdk/pdfwindow/PWL_Utils.h",
     "fpdfsdk/pdfwindow/PWL_Wnd.cpp",
     "fpdfsdk/pdfwindow/PWL_Wnd.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("javascript") {
   sources = [
     "fpdfsdk/javascript/ijs_context.h",
     "fpdfsdk/javascript/ijs_runtime.h",
   ]
   if (pdf_enable_v8) {
     sources += [
       "fpdfsdk/javascript/Consts.cpp",
@@ skipping 42 matching lines @@
       "//v8",
       "//v8/include",
     ]
     public_deps = [
       "//v8",
     ]
     configs += [ "//v8:external_startup_data" ]
   } else {
     sources += [ "fpdfsdk/javascript/JS_Runtime_Stub.cpp" ]
   }
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 static_library("formfiller") {
   sources = [
     "fpdfsdk/formfiller/cba_fontmap.cpp",
     "fpdfsdk/formfiller/cba_fontmap.h",
     "fpdfsdk/formfiller/cffl_checkbox.cpp",
     "fpdfsdk/formfiller/cffl_checkbox.h",
     "fpdfsdk/formfiller/cffl_combobox.cpp",
     "fpdfsdk/formfiller/cffl_combobox.h",
     "fpdfsdk/formfiller/cffl_formfiller.cpp",
     "fpdfsdk/formfiller/cffl_formfiller.h",
     "fpdfsdk/formfiller/cffl_iformfiller.cpp",
     "fpdfsdk/formfiller/cffl_iformfiller.h",
     "fpdfsdk/formfiller/cffl_listbox.cpp",
     "fpdfsdk/formfiller/cffl_listbox.h",
     "fpdfsdk/formfiller/cffl_pushbutton.cpp",
     "fpdfsdk/formfiller/cffl_pushbutton.h",
     "fpdfsdk/formfiller/cffl_radiobutton.cpp",
     "fpdfsdk/formfiller/cffl_radiobutton.h",
     "fpdfsdk/formfiller/cffl_textfield.cpp",
     "fpdfsdk/formfiller/cffl_textfield.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 if (pdf_enable_xfa) {
   static_library("fpdfxfa") {
     sources = [
       "fpdfsdk/fpdfxfa/fpdfxfa_app.cpp",
       "fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp",
       "fpdfsdk/fpdfxfa/fpdfxfa_page.cpp",
       "fpdfsdk/fpdfxfa/fpdfxfa_util.cpp",
       "fpdfsdk/fpdfxfa/include/fpdfxfa_app.h",
       "fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h",
       "fpdfsdk/fpdfxfa/include/fpdfxfa_page.h",
       "fpdfsdk/fpdfxfa/include/fpdfxfa_util.h",
     ]
     deps = [
       ":xfa",
     ]
-    configs += [ ":pdfium_config" ]
+    configs += [ ":pdfium_core_config" ]
   }
 
   static_library("xfa") {
     sources = [
       "xfa/fde/cfde_path.cpp",
       "xfa/fde/cfde_path.h",
       "xfa/fde/cfde_txtedtbuf.cpp",
       "xfa/fde/cfde_txtedtbuf.h",
       "xfa/fde/cfde_txtedtbufiter.cpp",
       "xfa/fde/cfde_txtedtbufiter.h",
@@ skipping 680 matching lines @@
         "//v8/include",
       ]
       public_deps = [
         "//v8",
       ]
       deps = [
         "//v8:v8_libplatform",
       ]
     }
     configs += [
-      ":pdfium_config",
+      ":pdfium_core_config",
       ":xfa_warnings",
     ]
   }
 }
 
 test("pdfium_unittests") {
   sources = [
     "core/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp",
     "core/fpdfapi/fpdf_font/fpdf_font_unittest.cpp",
     "core/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp",
@@ skipping 34 matching lines @@
       "xfa/fxfa/parser/xfa_utils_imp_unittest.cpp",
     ]
   }
   if (pdf_enable_v8) {
     sources += [ "fpdfsdk/javascript/public_methods_unittest.cpp" ]
     include_dirs += [
       "//v8",
       "//v8/include",
     ]
   }
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 test("pdfium_embeddertests") {
   sources = [
     "core/fpdfapi/fpdf_page/fpdf_page_func_embeddertest.cpp",
     "core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp",
     "core/fpdfapi/fpdf_parser/cpdf_security_handler_embeddertest.cpp",
     "core/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp",
     "core/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp",
     "core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp",
@@ skipping 32 matching lines @@
     deps += [
       "//v8",
       "//v8:v8_libplatform",
     ]
     include_dirs += [
       "//v8",
       "//v8/include",
     ]
     configs += [ "//v8:external_startup_data" ]
   }
-  configs += [ ":pdfium_config" ]
+  configs += [ ":pdfium_core_config" ]
 }
 
 if (pdf_is_standalone) {
   source_set("samples") {
     testonly = true
     deps = [
       "//samples",
     ]
   }
 }