Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 2041033002: Moved ButtonInkDropDelegate logic into InkDropHostView and deleted InkDropDelegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed merge conflict in custom_button.cc Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_button.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc
index 741c8c3a7c00f9408f72cc1aaee127c197c602d6..82a4f391e2685c6854abd75b387b9c39adc7ceed 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc
@@ -22,7 +22,6 @@
#include "ui/display/display.h"
#include "ui/display/screen.h"
#include "ui/strings/grit/ui_strings.h"
-#include "ui/views/animation/button_ink_drop_delegate.h"
#include "ui/views/controls/button/label_button_border.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/controls/menu/menu_model_adapter.h"
@@ -38,8 +37,7 @@ ToolbarButton::ToolbarButton(Profile* profile,
menu_showing_(false),
y_position_on_lbuttondown_(0),
show_menu_factory_(this) {
- set_ink_drop_delegate(
- base::WrapUnique(new views::ButtonInkDropDelegate(this, this)));
+ SetHasInkDrop(true);
set_has_ink_drop_action_on_click(true);
set_context_menu_controller(this);
if (ui::MaterialDesignController::IsModeMaterial())
@@ -222,7 +220,7 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {
menu_showing_ = true;
- ink_drop_delegate()->OnAction(views::InkDropState::ACTIVATED);
+ AnimateInkDrop(views::InkDropState::ACTIVATED);
// Exit if the model is null.
if (!model_.get())
@@ -242,7 +240,7 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {
}
void ToolbarButton::OnMenuClosed() {
- ink_drop_delegate()->OnAction(views::InkDropState::DEACTIVATED);
+ AnimateInkDrop(views::InkDropState::DEACTIVATED);
menu_showing_ = false;
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc ('k') | ui/views/animation/button_ink_drop_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698