Moved ButtonInkDropDelegate logic into InkDropHostView and deleted InkDropDelegates.

Moved ButtonInkDropDelegate logic into InkDropHostView and deleted InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*

Committed: https://crrev.com/810026326fbcd82da2540a7efb4e601cd570e4df
Cr-Commit-Position: refs/heads/master@{#398375}

[bruthig, 2016-06-06 16:39:31]

Description was changed from

==========
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted
InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*
==========

to

==========
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted
InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*
==========

[bruthig, 2016-06-06 16:40:00]

bruthig@chromium.org changed reviewers:
+ mohsen@chromium.org

[bruthig, 2016-06-06 16:40:01]

mohsen@, can you PTAL?

[bruthig, 2016-06-06 18:57:59]

https://codereview.chromium.org/2041033002/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_host_view.cc (right):

https://codereview.chromium.org/2041033002/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_host_view.cc:44: InkDropGestureHandler(View* view,
InkDrop* ink_drop) {}
FIXME(bruthig): |view| and |ink_drop| are not used.

[mohsen, 2016-06-07 06:10:31]

LGTM

https://codereview.chromium.org/2041033002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_item_view_md.cc (right):

https://codereview.chromium.org/2041033002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_item_view_md.cc:153: // Allows the
DownloadItemViewMd to control the InkDrop on the drop down button.
Can you just make InkDropHostView::ink_drop() public? We'll probably need to
access it in other places, too (e.g. ShelfView).

[bruthig, 2016-06-07 15:14:51]

bruthig@chromium.org changed reviewers:
+ sky@chromium.org

[bruthig, 2016-06-07 15:14:52]

sky@, can you provide an OWNER's review for:
 - ash/*
 - chrome/browser/*
 - ui/views/controls/*
 - ui/views/views.gyp

https://codereview.chromium.org/2041033002/diff/1/chrome/browser/ui/views/dow...
File chrome/browser/ui/views/download/download_item_view_md.cc (right):

https://codereview.chromium.org/2041033002/diff/1/chrome/browser/ui/views/dow...
chrome/browser/ui/views/download/download_item_view_md.cc:153: // Allows the
DownloadItemViewMd to control the InkDrop on the drop down button.
On 2016/06/07 06:10:31, mohsen wrote:
> Can you just make InkDropHostView::ink_drop() public? We'll probably need to
> access it in other places, too (e.g. ShelfView).

Let's discuss the use case offline.  I'm hesitant to make ink_drop() public
because I want InkDropHostView descendants to use
InkDropHostView::AnimateInkDrop() so it captures the ui::Event for centering and
disabling ripples.

https://codereview.chromium.org/2041033002/diff/1/ui/views/animation/ink_drop...
File ui/views/animation/ink_drop_host_view.cc (right):

https://codereview.chromium.org/2041033002/diff/1/ui/views/animation/ink_drop...
ui/views/animation/ink_drop_host_view.cc:44: InkDropGestureHandler(View* view,
InkDrop* ink_drop) {}
On 2016/06/06 18:57:59, bruthig wrote:
> FIXME(bruthig): |view| and |ink_drop| are not used.  

Done.

[sky, 2016-06-07 17:23:47]

LGTM

[bruthig, 2016-06-07 17:25:59]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-06-07 17:26:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mohsen@chromium.org
Link to the patchset: https://codereview.chromium.org/2041033002/#ps40001
(title: "Removed ink_drop_hover_observer.h from views.gyp.")

[commit-bot: I haz the power, 2016-06-07 17:26:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041033002/40001

[commit-bot: I haz the power, 2016-06-07 17:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:34:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bruthig, 2016-06-07 17:36:33]

The CQ bit was checked by bruthig@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:37:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041033002/40001

[commit-bot: I haz the power, 2016-06-07 17:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 17:45:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bruthig, 2016-06-07 20:55:59]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-06-07 20:56:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mohsen@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2041033002/#ps60001
(title: "Fixed merge conflict in custom_button.cc")

[commit-bot: I haz the power, 2016-06-07 21:03:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2041033002/60001

[commit-bot: I haz the power, 2016-06-07 21:29:52]

Description was changed from

==========
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted
InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*
==========

to

==========
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted
InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*
==========

[commit-bot: I haz the power, 2016-06-07 21:29:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-07 21:31:18]

Description was changed from

==========
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted
InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*
==========

to

==========
Moved ButtonInkDropDelegate logic into InkDropHostView and deleted
InkDropDelegates.

Common responsibility was split between the InkDropDelegate and the
InkDropHostView.  This change consolidates that and will make it a
easier to implement https://crbug.com/597273 and https://crbug.com/595315.

This change regresses InkDrops from being centered on download buttons on Linux.
However, this will be fixed shortly after by a follow-up CL.

BUG=None

TEST=CustomButtonTest.*
TEST=MenuButtonTest.*
TEST=LabelButtonTest.*

Committed: https://crrev.com/810026326fbcd82da2540a7efb4e601cd570e4df
Cr-Commit-Position: refs/heads/master@{#398375}
==========

[commit-bot: I haz the power, 2016-06-07 21:31:20]

Patchset 4 (id:??) landed as
https://crrev.com/810026326fbcd82da2540a7efb4e601cd570e4df
Cr-Commit-Position: refs/heads/master@{#398375}