Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2041033002: Moved ButtonInkDropDelegate logic into InkDropHostView and deleted InkDropDelegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed merge conflict in custom_button.cc Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
index ce5fcaa733f89c12b516e4cb6cb5b0c2701ef05e..50d6d27680a68c8f00d1b71a153d1ebe3af5a134 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
@@ -26,7 +26,6 @@
#include "ui/gfx/image/image_skia_operations.h"
#include "ui/gfx/image/image_skia_source.h"
#include "ui/resources/grit/ui_resources.h"
-#include "ui/views/animation/button_ink_drop_delegate.h"
#include "ui/views/controls/button/label_button_border.h"
#include "ui/views/controls/menu/menu_controller.h"
#include "ui/views/controls/menu/menu_model_adapter.h"
@@ -62,8 +61,7 @@ ToolbarActionView::ToolbarActionView(
wants_to_run_(false),
menu_(nullptr),
weak_factory_(this) {
- set_ink_drop_delegate(
- base::WrapUnique(new views::ButtonInkDropDelegate(this, this)));
+ SetHasInkDrop(true);
set_has_ink_drop_action_on_click(true);
set_id(VIEW_ID_BROWSER_ACTION);
view_controller_->SetDelegate(this);
@@ -81,9 +79,6 @@ ToolbarActionView::ToolbarActionView(
}
ToolbarActionView::~ToolbarActionView() {
- // Avoid access to a destroyed InkDropDelegate when the |pressed_lock_| is
- // destroyed.
- set_ink_drop_delegate(nullptr);
view_controller_->SetDelegate(nullptr);
}
@@ -195,7 +190,7 @@ bool ToolbarActionView::OnMousePressed(const ui::MouseEvent& event) {
// TODO(bruthig): The ACTION_PENDING triggering logic should be in
// MenuButton::OnPressed() however there is a bug with the pressed state
// logic in MenuButton. See http://crbug.com/567252.
- ink_drop_delegate()->OnAction(views::InkDropState::ACTION_PENDING);
+ AnimateInkDrop(views::InkDropState::ACTION_PENDING);
}
return MenuButton::OnMousePressed(event);
}
« no previous file with comments | « chrome/browser/ui/views/toolbar/app_menu_button.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698