Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome/browser/ui/views/toolbar/app_menu_button.cc

Issue 2041033002: Moved ButtonInkDropDelegate logic into InkDropHostView and deleted InkDropDelegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/app_menu_button.h" 5 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "chrome/browser/themes/theme_properties.h" 12 #include "chrome/browser/themes/theme_properties.h"
13 #include "chrome/browser/ui/browser.h" 13 #include "chrome/browser/ui/browser.h"
14 #include "chrome/browser/ui/layout_constants.h" 14 #include "chrome/browser/ui/layout_constants.h"
15 #include "chrome/browser/ui/toolbar/app_menu_model.h" 15 #include "chrome/browser/ui/toolbar/app_menu_model.h"
16 #include "chrome/browser/ui/views/extensions/browser_action_drag_data.h" 16 #include "chrome/browser/ui/views/extensions/browser_action_drag_data.h"
17 #include "chrome/browser/ui/views/toolbar/app_menu.h" 17 #include "chrome/browser/ui/views/toolbar/app_menu.h"
18 #include "chrome/browser/ui/views/toolbar/toolbar_view.h" 18 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
19 #include "extensions/common/feature_switch.h" 19 #include "extensions/common/feature_switch.h"
20 #include "grit/theme_resources.h" 20 #include "grit/theme_resources.h"
21 #include "ui/base/material_design/material_design_controller.h" 21 #include "ui/base/material_design/material_design_controller.h"
22 #include "ui/base/resource/resource_bundle.h" 22 #include "ui/base/resource/resource_bundle.h"
23 #include "ui/base/theme_provider.h" 23 #include "ui/base/theme_provider.h"
24 #include "ui/gfx/color_palette.h" 24 #include "ui/gfx/color_palette.h"
25 #include "ui/gfx/paint_vector_icon.h" 25 #include "ui/gfx/paint_vector_icon.h"
26 #include "ui/gfx/vector_icons_public.h" 26 #include "ui/gfx/vector_icons_public.h"
27 #include "ui/keyboard/keyboard_controller.h" 27 #include "ui/keyboard/keyboard_controller.h"
28 #include "ui/views/animation/button_ink_drop_delegate.h"
29 #include "ui/views/controls/button/label_button_border.h" 28 #include "ui/views/controls/button/label_button_border.h"
30 #include "ui/views/controls/menu/menu_listener.h" 29 #include "ui/views/controls/menu/menu_listener.h"
31 #include "ui/views/metrics.h" 30 #include "ui/views/metrics.h"
32 #include "ui/views/painter.h" 31 #include "ui/views/painter.h"
33 32
34 // static 33 // static
35 bool AppMenuButton::g_open_app_immediately_for_testing = false; 34 bool AppMenuButton::g_open_app_immediately_for_testing = false;
36 35
37 AppMenuButton::AppMenuButton(ToolbarView* toolbar_view) 36 AppMenuButton::AppMenuButton(ToolbarView* toolbar_view)
38 : views::MenuButton(base::string16(), toolbar_view, false), 37 : views::MenuButton(base::string16(), toolbar_view, false),
39 severity_(AppMenuIconPainter::SEVERITY_NONE), 38 severity_(AppMenuIconPainter::SEVERITY_NONE),
40 toolbar_view_(toolbar_view), 39 toolbar_view_(toolbar_view),
41 allow_extension_dragging_( 40 allow_extension_dragging_(
42 extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()), 41 extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()),
43 margin_trailing_(0), 42 margin_trailing_(0),
44 weak_factory_(this) { 43 weak_factory_(this) {
45 set_ink_drop_delegate( 44 SetHasInkDrop(true);
46 base::WrapUnique(new views::ButtonInkDropDelegate(this, this)));
47 if (!ui::MaterialDesignController::IsModeMaterial()) 45 if (!ui::MaterialDesignController::IsModeMaterial())
48 icon_painter_.reset(new AppMenuIconPainter(this)); 46 icon_painter_.reset(new AppMenuIconPainter(this));
49 } 47 }
50 48
51 AppMenuButton::~AppMenuButton() {} 49 AppMenuButton::~AppMenuButton() {}
52 50
53 void AppMenuButton::SetSeverity(AppMenuIconPainter::Severity severity, 51 void AppMenuButton::SetSeverity(AppMenuIconPainter::Severity severity,
54 bool animate) { 52 bool animate) {
55 if (ui::MaterialDesignController::IsModeMaterial()) { 53 if (ui::MaterialDesignController::IsModeMaterial()) {
56 severity_ = severity; 54 severity_ = severity;
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 views::MenuButton::OnPaint(canvas); 245 views::MenuButton::OnPaint(canvas);
248 if (ui::MaterialDesignController::IsModeMaterial()) 246 if (ui::MaterialDesignController::IsModeMaterial())
249 return; 247 return;
250 // Use GetPreferredSize() to center the icon inside the visible bounds rather 248 // Use GetPreferredSize() to center the icon inside the visible bounds rather
251 // than the whole size() (which may refer to hit test region extended to the 249 // than the whole size() (which may refer to hit test region extended to the
252 // end of the toolbar in maximized mode). 250 // end of the toolbar in maximized mode).
253 icon_painter_->Paint(canvas, GetThemeProvider(), 251 icon_painter_->Paint(canvas, GetThemeProvider(),
254 gfx::Rect(GetPreferredSize()), 252 gfx::Rect(GetPreferredSize()),
255 AppMenuIconPainter::BEZEL_NONE); 253 AppMenuIconPainter::BEZEL_NONE);
256 } 254 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698