Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2040923002: Addendum to OpenType feature detection simplification (Closed)

Created:
4 years, 6 months ago by drott
Modified:
4 years, 6 months ago
Reviewers:
behdad
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Addendum to OpenType feature detection simplification Addressing Behdad's review comment. Reland after revert in 3d9eeeefe, test expectation can be rebaselined. Landing TBR, since previously LGTM'ed in https://codereview.chromium.org/2026433002 BUG=603137 TBR=behdad Committed: https://crrev.com/4095e6cfa57acce24b79f4c3ec9d7f2f70e34643 Cr-Commit-Position: refs/heads/master@{#398004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040923002/1
4 years, 6 months ago (2016-06-06 07:52:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 11:21:54 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 11:23:40 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4095e6cfa57acce24b79f4c3ec9d7f2f70e34643
Cr-Commit-Position: refs/heads/master@{#398004}

Powered by Google App Engine
This is Rietveld 408576698