Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2026433002:
Addendum to OpenType feature detection simplification (Closed)
|
Created:
4 years, 6 months ago by drott Modified:
4 years, 6 months ago Reviewers:
behdad CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAddendum to OpenType feature detection simplification
Addressing Behdad's review comment.
BUG=603137
TBR=behdad
Committed: https://crrev.com/09e8b8a7b8da00f9595df458606c2a133f99a74f
Cr-Commit-Position: refs/heads/master@{#396714}
Patch Set 1 #
Messages
Total messages: 14 (4 generated)
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by drott@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026433002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Addendum to OpenType feature detection simplification Addressing Behdad's review comment. BUG=603137 TBR=behdad ========== to ========== Addendum to OpenType feature detection simplification Addressing Behdad's review comment. BUG=603137 TBR=behdad Committed: https://crrev.com/09e8b8a7b8da00f9595df458606c2a133f99a74f Cr-Commit-Position: refs/heads/master@{#396714} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/09e8b8a7b8da00f9595df458606c2a133f99a74f Cr-Commit-Position: refs/heads/master@{#396714}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2027623002/ by guidou@chromium.org. The reason for reverting is: This CL is suspect of causing fast/text/font-features/caps-native-synthesis.html to fail in the WebKit Win10 bot. See: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1... https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10?numbuild... I will reland if the revert doesn't fix the bot..
Message was sent while issue was closed.
On 2016/05/31 13:50:13, Guido Urdaneta wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2027623002/ by mailto:guidou@chromium.org. > > The reason for reverting is: This CL is suspect of causing > fast/text/font-features/caps-native-synthesis.html to fail in the WebKit Win10 > bot. > > See: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1... > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10?numbuild... > > I will reland if the revert doesn't fix the bot.. The revert fixed the bot, so take a look at that when relanding the CL.
Message was sent while issue was closed.
On 2016/05/31 at 16:54:11, guidou wrote: > The revert fixed the bot, so take a look at that when relanding the CL. Looks like this changed the advance width for the space character in the synthetic small-caps part of this test result https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/107... - I think we can rebaseline this. But any further idea how this CL affects the result, Behdad?
Message was sent while issue was closed.
On 2016/06/01 06:12:29, drott wrote: > On 2016/05/31 at 16:54:11, guidou wrote: > > > The revert fixed the bot, so take a look at that when relanding the CL. > > Looks like this changed the advance width for the space character in the > synthetic small-caps part of this test result > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/107... > - I think we can rebaseline this. But any further idea how this CL affects the > result, Behdad? If it's just width of space, it's exactly the kind of thing that this code is supposed to detect. So, to me, it's ok to rebaseline.
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
