Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2040913002: [build] Roll android_tools to 04c2c06 (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Roll android_tools to 04c2c06 This ports: https://codereview.chromium.org/1991343002 BUG=chromium:599327 Committed: https://crrev.com/8ee22392f834a1ef8778f0f62302a87c198ef20c Cr-Commit-Position: refs/heads/master@{#36730}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M DEPS View 2 chunks +3 lines, -1 line 1 comment Download
M gypfiles/standalone.gypi View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2040913002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/2040913002/diff/1/DEPS#newcode47 DEPS:47: The auto-roller is blocked on the missing recursion.
4 years, 6 months ago (2016-06-06 07:42:17 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040913002/1
4 years, 6 months ago (2016-06-06 07:43:01 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 08:02:53 UTC) #7
ulan
lgtm
4 years, 6 months ago (2016-06-06 08:41:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040913002/1
4 years, 6 months ago (2016-06-06 08:45:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 08:47:35 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 08:49:05 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8ee22392f834a1ef8778f0f62302a87c198ef20c
Cr-Commit-Position: refs/heads/master@{#36730}

Powered by Google App Engine
This is Rietveld 408576698