Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1991343002: [Android] Roll the NDK to r11c. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 6 months ago
Reviewers:
vapier, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Roll the NDK to r11c. Also rolls breakpad to pick up an NDK fix. BUG=599327 Committed: https://crrev.com/7caea6eeb8d0cbce90c6749bd21a436a6f372e56 Cr-Commit-Position: refs/heads/master@{#397885}

Patch Set 1 #

Patch Set 2 : android_tools change landed #

Patch Set 3 : + NDK roll clobber mechanism #

Patch Set 4 : rebase #

Patch Set 5 : breakpad fixes #

Patch Set 6 : rebase #

Patch Set 7 : rebase 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M DEPS View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 4 chunks +5 lines, -0 lines 0 comments Download
M build/config/android/BUILD.gn View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/config.gni View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
jbudorick
PTAL. Not planning to land prior to https://groups.google.com/a/chromium.org/d/msg/chromium-dev/8Je_PO9hV1U/AzE0D34NAQAJ linux_android_rel_ng failed on the current patchset thanks ...
4 years, 6 months ago (2016-06-02 18:48:16 UTC) #2
agrieve
On 2016/06/02 18:48:16, jbudorick wrote: > PTAL. Not planning to land prior to > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/8Je_PO9hV1U/AzE0D34NAQAJ ...
4 years, 6 months ago (2016-06-02 19:00:26 UTC) #3
jbudorick
On 2016/06/02 19:00:26, agrieve wrote: > On 2016/06/02 18:48:16, jbudorick wrote: > > PTAL. Not ...
4 years, 6 months ago (2016-06-02 19:03:54 UTC) #5
jbudorick
... and +vapier to review the breakpad roll
4 years, 6 months ago (2016-06-02 19:04:29 UTC) #7
vapier
lgtm the breakpad delta seems pretty harmless
4 years, 6 months ago (2016-06-02 19:06:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991343002/120001
4 years, 6 months ago (2016-06-04 00:12:57 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-04 01:41:43 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 01:42:47 UTC) #14
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7caea6eeb8d0cbce90c6749bd21a436a6f372e56
Cr-Commit-Position: refs/heads/master@{#397885}

Powered by Google App Engine
This is Rietveld 408576698