Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2040803005: [build] Fix default for target_arch (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Michael Achenbach, Jarin, bgeron
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix default for target_arch Fix after https://codereview.chromium.org/2028623002/ BUG=chromium:474921, chromium:616032 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Committed: https://crrev.com/9dcb67dd174fefc98f9c964ef54fed8fe6feb224 Cr-Commit-Position: refs/heads/master@{#36733}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M gypfiles/standalone.gypi View 2 chunks +19 lines, -15 lines 1 comment Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040803005/1
4 years, 6 months ago (2016-06-06 09:04:10 UTC) #2
Michael Achenbach
TBR https://codereview.chromium.org/2040803005/diff/1/gypfiles/standalone.gypi File gypfiles/standalone.gypi (right): https://codereview.chromium.org/2040803005/diff/1/gypfiles/standalone.gypi#newcode52 gypfiles/standalone.gypi:52: 'variables': { We have to go deeper...
4 years, 6 months ago (2016-06-06 09:07:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2040803005/1
4 years, 6 months ago (2016-06-06 09:08:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 09:10:28 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9dcb67dd174fefc98f9c964ef54fed8fe6feb224 Cr-Commit-Position: refs/heads/master@{#36733}
4 years, 6 months ago (2016-06-06 09:12:53 UTC) #13
Michael Achenbach
4 years, 6 months ago (2016-06-06 11:00:13 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2039853002/ by machenbach@chromium.org.

The reason for reverting is: sysroot logic breaks "make arm".

Powered by Google App Engine
This is Rietveld 408576698