Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: src/isolate.h

Issue 2040683002: Remove dependencies of V8 on cpu-profiler is_profiling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove extra include's Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index a1d0e887dbe21d512a9115520ad9cd423ea8be6e..762c88a64e74f8ff5f175744cc2a330f4533fe66 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -916,6 +916,9 @@ class Isolate {
Debug* debug() { return debug_; }
+ void set_profiling(bool value) { is_profiling_ = value; }
Yang 2016/06/08 07:45:18 You could declare this field including accessors b
alph 2016/06/08 18:38:42 Thanks. Done.
+ bool is_profiling() const { return is_profiling_; }
+ bool* is_profiling_address() { return &is_profiling_; }
Yang 2016/06/08 07:45:18 You could add an entry to FOR_EACH_ISOLATE_ADDRESS
alph 2016/06/08 18:38:42 It doesn't seem I need this as the entry has a ded
CpuProfiler* cpu_profiler() const { return cpu_profiler_; }
HeapProfiler* heap_profiler() const { return heap_profiler_; }
@@ -1332,6 +1335,9 @@ class Isolate {
JSObject::SpillInformation js_spill_information_;
#endif
+ // True if the isolate is being profiled.
+ // Causes collection of extra compile info.
+ bool is_profiling_;
Debug* debug_;
CpuProfiler* cpu_profiler_;
HeapProfiler* heap_profiler_;
« no previous file with comments | « src/ic/ic-compiler.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698