Remove dependencies of V8 on cpu-profiler is_profiling.

src/isolate.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ISOLATE_H_
 #define V8_ISOLATE_H_
 
 #include <queue>
 #include <set>
 
@@ skipping 898 matching lines @@
 
   RegExpStack* regexp_stack() { return regexp_stack_; }
 
   unibrow::Mapping<unibrow::Ecma262Canonicalize>*
       interp_canonicalize_mapping() {
     return &regexp_macro_assembler_canonicalize_;
   }
 
   Debug* debug() { return debug_; }
 
+  void set_profiling(bool value) { is_profiling_ = value; }

[Yang, 2016/06/08 07:45:18]

You could declare this field including accessors by adding an entry to
ISOLATE_INIT_LIST macro.

[alph, 2016/06/08 18:38:42]

Thanks. Done.

+  bool is_profiling() const { return is_profiling_; }
+  bool* is_profiling_address() { return &is_profiling_; }

[Yang, 2016/06/08 07:45:18]

You could add an entry to FOR_EACH_ISOLATE_ADDRESS_NAME macro for this.

[alph, 2016/06/08 18:38:42]

It doesn't seem I need this as the entry has a dedicated accessor function in
ExternalReference class.

   CpuProfiler* cpu_profiler() const { return cpu_profiler_; }
   HeapProfiler* heap_profiler() const { return heap_profiler_; }
 
 #ifdef DEBUG
   HistogramInfo* heap_histograms() { return heap_histograms_; }
 
   JSObject::SpillInformation* js_spill_information() {
     return &js_spill_information_;
   }
 #endif
@@ skipping 396 matching lines @@
 
   // Time stamp at initialization.
   double time_millis_at_init_;
 
 #ifdef DEBUG
   // A static array of histogram info for each type.
   HistogramInfo heap_histograms_[LAST_TYPE + 1];
   JSObject::SpillInformation js_spill_information_;
 #endif
 
+  // True if the isolate is being profiled.
+  // Causes collection of extra compile info.
+  bool is_profiling_;
   Debug* debug_;
   CpuProfiler* cpu_profiler_;
   HeapProfiler* heap_profiler_;
   FunctionEntryHook function_entry_hook_;
 
   interpreter::Interpreter* interpreter_;
 
   typedef std::pair<InterruptCallback, void*> InterruptEntry;
   std::queue<InterruptEntry> api_interrupts_queue_;
 
@@ skipping 291 matching lines @@
 
   EmbeddedVector<char, 128> filename_;
   FILE* file_;
   int scope_depth_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_ISOLATE_H_