Remove dependencies of V8 on cpu-profiler is_profiling.

Remove dependencies of V8 on cpu-profiler is_profiling.

Move is_profiling to the isolate for now.

BUG=v8:4789
Committed: https://crrev.com/81c8ce723a44cbdb9203575b022deee517981fe9
Cr-Commit-Position: refs/heads/master@{#36838}

[alph, 2016-06-04 02:37:56]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-04 02:38:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/1

[commit-bot: I haz the power, 2016-06-04 03:08:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 03:08:07]

Dry run: This issue passed the CQ dry run.

[alph, 2016-06-04 15:00:57]

alph@chromium.org changed reviewers:
+ jochen@chromium.org, lpy@chromium.org, yangguo@chromium.org

[lpy, 2016-06-06 17:11:11]

lgtm

[jochen (gone - plz use gerrit), 2016-06-07 15:05:37]

technically, this would be Isolate::is_being_profiled() :)

anyways, lgtm either way

[alph, 2016-06-07 15:58:35]

On 2016/06/07 15:05:37, jochen wrote:
> technically, this would be Isolate::is_being_profiled() :)
> 
> anyways, lgtm either way

technically yes! :-)
but this one is more compact. in fact I'd like to get rid of it later as the
isolate shouldn't know if it's being profiled or not.

[alph, 2016-06-07 15:58:40]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:01:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/1

[alph, 2016-06-07 16:09:11]

Yang, could you please take a look.

[commit-bot: I haz the power, 2016-06-07 16:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:33:26]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16673)

[lpy, 2016-06-07 17:46:40]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 17:46:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/1

[alph, 2016-06-07 17:51:53]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 17:52:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/20001

[alph, 2016-06-07 18:07:33]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 18:07:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/40001

[commit-bot: I haz the power, 2016-06-07 18:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 18:33:27]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-06-08 07:45:18]

LGTM. Some comments.

https://codereview.chromium.org/2040683002/diff/40001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2040683002/diff/40001/src/isolate.h#newcode919
src/isolate.h:919: void set_profiling(bool value) { is_profiling_ = value; }
You could declare this field including accessors by adding an entry to
ISOLATE_INIT_LIST macro.

https://codereview.chromium.org/2040683002/diff/40001/src/isolate.h#newcode921
src/isolate.h:921: bool* is_profiling_address() { return &is_profiling_; }
You could add an entry to FOR_EACH_ISOLATE_ADDRESS_NAME macro for this.

[alph, 2016-06-08 18:38:42]

https://codereview.chromium.org/2040683002/diff/40001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/2040683002/diff/40001/src/isolate.h#newcode919
src/isolate.h:919: void set_profiling(bool value) { is_profiling_ = value; }
On 2016/06/08 07:45:18, Yang wrote:
> You could declare this field including accessors by adding an entry to
> ISOLATE_INIT_LIST macro.

Thanks. Done.

https://codereview.chromium.org/2040683002/diff/40001/src/isolate.h#newcode921
src/isolate.h:921: bool* is_profiling_address() { return &is_profiling_; }
On 2016/06/08 07:45:18, Yang wrote:
> You could add an entry to FOR_EACH_ISOLATE_ADDRESS_NAME macro for this.

It doesn't seem I need this as the entry has a dedicated accessor function in
ExternalReference class.

[alph, 2016-06-08 18:40:01]

The CQ bit was checked by alph@chromium.org

[alph, 2016-06-08 18:40:01]

The patchset sent to the CQ was uploaded after l-g-t-m from lpy@chromium.org,
jochen@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2040683002/#ps60001
(title: "use macro for declaring is_profiling")

[commit-bot: I haz the power, 2016-06-08 18:40:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/60001

[commit-bot: I haz the power, 2016-06-08 18:44:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 18:44:39]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16780)

[alph, 2016-06-08 19:37:54]

alph@chromium.org changed reviewers:
+ bmeurer@chromium.org

[alph, 2016-06-08 19:37:55]

Benedikt, could you please take a look.

[Benedikt Meurer, 2016-06-09 04:23:44]

LGTM  (rubber-stamped)

[alph, 2016-06-09 05:21:22]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-06-09 05:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040683002/60001

[commit-bot: I haz the power, 2016-06-09 05:23:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-09 05:25:21]

Description was changed from

==========
Remove dependencies of V8 on cpu-profiler is_profiling.

Move is_profiling to the isolate for now.

BUG=v8:4789
==========

to

==========
Remove dependencies of V8 on cpu-profiler is_profiling.

Move is_profiling to the isolate for now.

BUG=v8:4789

Committed: https://crrev.com/81c8ce723a44cbdb9203575b022deee517981fe9
Cr-Commit-Position: refs/heads/master@{#36838}
==========

[commit-bot: I haz the power, 2016-06-09 05:25:22]

Patchset 4 (id:??) landed as
https://crrev.com/81c8ce723a44cbdb9203575b022deee517981fe9
Cr-Commit-Position: refs/heads/master@{#36838}