Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep
Patch Set: Rebased, and closure annotations Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
diff --git a/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h b/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
index 534242f48ed259591d428219faff734fd5873778..30ede5e6555d841a5ed7a7309ae40194fa8f1c4f 100644
--- a/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
+++ b/third_party/WebKit/Source/modules/filesystem/SyncCallbackHelper.h
@@ -119,10 +119,14 @@ private:
return new ErrorCallbackImpl(helper);
}
- void handleEvent(FileError* error) override
+ void handleEvent(DOMException* error) override
{
- ASSERT(error);
- m_helper->setError(error->code());
+ NOTREACHED();
+ }
+
+ void handleEvent(FileError::ErrorCode error) override
+ {
+ m_helper->setError(error);
}
DEFINE_INLINE_TRACE()
@@ -139,9 +143,9 @@ private:
Member<HelperType> m_helper;
};
- void setError(FileError::ErrorCode code)
+ void setError(FileError::ErrorCode error)
{
- m_errorCode = code;
+ m_errorCode = error;
m_completed = true;
}

Powered by Google App Engine
This is Rietveld 408576698